Re: [PATCH 2/2] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Hi Shawn,

> Oh, yes, I should have mentioned it in the cover-letter.  Instead of
> changing MAINTAINERS file in different subsystem patch series, which may
> introduce merge conflicts, we plan to update it with a separate patch
> adding all driver entries that lands on mainline, and get it in through
> arm-soc tree.  Are you okay with that?

Yup, totally fine! Good approach.

> > Is this the error handling (NACK, etc)? Then, it got lost now since we
> > don't reset the hardware anymore after timeouts. But that would have
> > meant that errors are only detected after the timeout was reached
> > instead of instantly? If so, no good design. But maybe I misunderstand.
> 
> Hmm, this doesn't make too much sense now, since this reset function is
> only being called at probe time to ensure the device is in a sane
> initial state.  There is no data transfer happening at this point at
> all.  I will drop these error bits checking from here, and add the error
> handling in irq handler.

Great, thanks!

> > How was this driver tested BTW?
> 
> The driver is being used to access an Audio codec on the I2C bus.

Nice. Can you also run 'i2cdetect' on the bus to see if we have proper
NAK handling? AFAICS this should be broken now. And very slow with
previous versions of the driver.

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]