From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michail Georgios Etairidis <m.etairidis@beck-ipc.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Andy Duan <fugang.duan@nxp.com>
Subject: Re: [PATCH] i2c: i2c-imx: Use correct function to write to register
Date: Tue, 20 Jun 2017 10:28:35 +0200 [thread overview]
Message-ID: <20170620082835.melqahq7lwyb2hfl@pengutronix.de> (raw)
In-Reply-To: <681500CE65202E47A192754B01DAB4671B1674818F@SDE12.beckipc.net>
Cc += Andy Duan
On Tue, Jun 20, 2017 at 10:20:42AM +0200, Michail Georgios Etairidis wrote:
>
> The i2c-imx driver incorrectly uses readb()/writeb() to read and
> write to the appropriate registers when performing a repeated start.
> The appropriate imx_i2c_read_reg()/imx_i2c_write_reg() functions
> should be used instead. Performing a repeated start results in
> a kernel panic. The platform is imx.
I really wonder why this didn't pop up earlier, maybe repeated start
just isn't that usual.
> Signed-off-by: Michail G Etairidis <m.etairidis@beck-ipc.com>
Fixes: ce1a78840ff7 ("i2c: imx: add DMA support for freescale i2c driver")
Fixes: 054b62d9f25c ("i2c: imx: fix the i2c bus hang issue when do repeat restart")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2017-06-20 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 13:28 [PATCH] i2c: i2c-imx: Use correct function to write to register Michail Georgios Etairidis
2017-06-19 14:46 ` Wolfram Sang
2017-06-20 8:20 ` AW: " Michail Georgios Etairidis
2017-06-20 8:28 ` Uwe Kleine-König [this message]
2017-06-20 9:23 ` Wolfram Sang
2017-06-22 8:54 ` Wolfram Sang
2017-06-19 18:54 ` Uwe Kleine-König
2017-06-20 1:50 ` Andy Duan
-- strict thread matches above, loose matches on Subject: below --
2017-06-08 17:07 Michail Georgios Etairidis
[not found] <681500CE65202E47A192754B01DAB4671B16747DB9@SDE12.beckipc.net>
2017-06-08 16:43 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620082835.melqahq7lwyb2hfl@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=m.etairidis@beck-ipc.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).