From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 2/2] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family Date: Thu, 22 Jun 2017 15:48:33 +0800 Message-ID: <20170622074831.GA23753@dragon> References: <1495947576-11037-1-git-send-email-shawnguo@kernel.org> <1495947576-11037-3-git-send-email-shawnguo@kernel.org> <20170619193130.velebm7p3r5ggaos@ninjato> <20170620025815.GA4818@x250> <20170620074126.GA1541@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.99]:53516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdFVHso (ORCPT ); Thu, 22 Jun 2017 03:48:44 -0400 Content-Disposition: inline In-Reply-To: <20170620074126.GA1541@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Baoyou Xie , Baoyou Xie , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Xin Zhou On Tue, Jun 20, 2017 at 09:41:26AM +0200, Wolfram Sang wrote: > > > How was this driver tested BTW? > > > > The driver is being used to access an Audio codec on the I2C bus. > > Nice. Can you also run 'i2cdetect' on the bus to see if we have proper > NAK handling? AFAICS this should be broken now. And very slow with > previous versions of the driver. Hmm, it seems that 'i2cdetect' works fine with the driver. $ i2cdetect -l i2c-0 i2c zx2967 i2c adapter I2C adapter $ i2cdetect 0 WARNING! This program can confuse your I2C bus, cause data loss and worse! I will probe file /dev/i2c-0. I will probe address range 0x03-0x77. Continue? [Y/n] Y 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- -- -- -- -- -- -- -- -- -- 10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 20: -- -- UU -- -- -- -- -- -- -- -- -- -- -- -- -- 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- -- 50: -- -- -- -- -- -- -- -- -- -- 5a -- -- -- -- -- 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 70: 70 -- -- -- -- -- -- -- $ The audio codec is on address 0x22. Why do you think it should be broken now? Shawn