linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb'
@ 2017-06-23 20:50 kbuild test robot
  2017-06-24 13:57 ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2017-06-23 20:50 UTC (permalink / raw)
  To: Baoyou Xie
  Cc: kbuild-all, linux-i2c, Wolfram Sang, Andy Shevchenko, Jun Nie,
	Shawn Guo

[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
head:   5ff37d1a67e2fed0cae537ad682abb7f6647cca4
commit: 9615a01f71ca02858f5265b1b545280758562aa2 [42/44] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 9615a01f71ca02858f5265b1b545280758562aa2
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_writesb':
>> drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' [-Werror=implicit-function-declaration]
     writesb(i2c->reg_base + reg, data, len);
     ^~~~~~~
   drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_readsb':
>> drivers/i2c/busses/i2c-zx2967.c:93:2: error: implicit declaration of function 'readsb' [-Werror=implicit-function-declaration]
     readsb(i2c->reg_base + reg, data, len);
     ^~~~~~
   cc1: some warnings being treated as errors

vim +/writesb +87 drivers/i2c/busses/i2c-zx2967.c

    81		return readl_relaxed(i2c->reg_base + reg);
    82	}
    83	
    84	static void zx2967_i2c_writesb(struct zx2967_i2c *i2c,
    85				       void *data, unsigned long reg, int len)
    86	{
  > 87		writesb(i2c->reg_base + reg, data, len);
    88	}
    89	
    90	static void zx2967_i2c_readsb(struct zx2967_i2c *i2c,
    91				      void *data, unsigned long reg, int len)
    92	{
  > 93		readsb(i2c->reg_base + reg, data, len);
    94	}
    95	
    96	static void zx2967_i2c_start_ctrl(struct zx2967_i2c *i2c)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47734 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb'
  2017-06-23 20:50 [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' kbuild test robot
@ 2017-06-24 13:57 ` Shawn Guo
  2017-06-24 14:15   ` Wolfram Sang
  0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2017-06-24 13:57 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Baoyou Xie, kbuild-all, linux-i2c, Wolfram Sang, Andy Shevchenko,
	Jun Nie

On Sat, Jun 24, 2017 at 04:50:44AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
> head:   5ff37d1a67e2fed0cae537ad682abb7f6647cca4
> commit: 9615a01f71ca02858f5265b1b545280758562aa2 [42/44] i2c: zx2967: add i2c controller driver for ZTE's zx2967 family
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 9615a01f71ca02858f5265b1b545280758562aa2
>         # save the attached .config to linux build tree
>         make.cross ARCH=ia64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_writesb':
> >> drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' [-Werror=implicit-function-declaration]
>      writesb(i2c->reg_base + reg, data, len);
>      ^~~~~~~
>    drivers/i2c/busses/i2c-zx2967.c: In function 'zx2967_i2c_readsb':
> >> drivers/i2c/busses/i2c-zx2967.c:93:2: error: implicit declaration of function 'readsb' [-Werror=implicit-function-declaration]
>      readsb(i2c->reg_base + reg, data, len);
>      ^~~~~~
>    cc1: some warnings being treated as errors

It's caused by that writesb/readsb are unavailable on ia64 architecture.
We do have the accessors in include/asm-generic/io.h, but ia64 asm io.h
doesn't include this header.  It seems that including the header in ia64
io.h causes more build issue.

I think what we should do is dropping COMPILE_TEST or adding !IA64
dependency.  @Wolfram, what do you think?

Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb'
  2017-06-24 13:57 ` Shawn Guo
@ 2017-06-24 14:15   ` Wolfram Sang
  2017-06-24 14:26     ` Shawn Guo
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2017-06-24 14:15 UTC (permalink / raw)
  To: Shawn Guo
  Cc: kbuild test robot, Baoyou Xie, kbuild-all, linux-i2c,
	Wolfram Sang, Andy Shevchenko, Jun Nie

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]


> I think what we should do is dropping COMPILE_TEST or adding !IA64
> dependency.  @Wolfram, what do you think?

Let's drop COMPILE_TEST for now, I'd say.

Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb'
  2017-06-24 14:15   ` Wolfram Sang
@ 2017-06-24 14:26     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-06-24 14:26 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: kbuild test robot, Baoyou Xie, kbuild-all, linux-i2c,
	Wolfram Sang, Andy Shevchenko, Jun Nie

On Sat, Jun 24, 2017 at 04:15:00PM +0200, Wolfram Sang wrote:
> 
> > I think what we should do is dropping COMPILE_TEST or adding !IA64
> > dependency.  @Wolfram, what do you think?
> 
> Let's drop COMPILE_TEST for now, I'd say.

I just sent you one patch doing that.

Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-24 14:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-23 20:50 [wsa:i2c/for-next 42/44] drivers/i2c/busses/i2c-zx2967.c:87:2: error: implicit declaration of function 'writesb' kbuild test robot
2017-06-24 13:57 ` Shawn Guo
2017-06-24 14:15   ` Wolfram Sang
2017-06-24 14:26     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).