From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] i2c: add helpers to ease DMA handling
Date: Tue, 27 Jun 2017 23:16:10 +0200 [thread overview]
Message-ID: <20170627211610.53oeludkm3sooo64@ninjato> (raw)
In-Reply-To: <CAMuHMdVe1tBMZO9weMsf2Tj7pQ_AUeVu_X=uKbs+JbziLFQHvQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
Hi Geert,
> > +static inline int i2c_check_msg_for_dma(struct i2c_msg *msg, unsigned int threshold,
> > + u8 **ptr_for_bounce_buf)
>
> __must_check?
Yes, why not.
> Isn't this function a bit large to be inlined?
That can be argued, yes. But I am unsure to bloat the core if the
function is so rarely needed...
> > +static inline void i2c_release_bounce_buf(struct i2c_msg *msg, u8 *bounce_buf)
>
> This one is smaller.
Yup, but of course, they should be put in the same place, whereever that may be.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-27 21:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 18:30 [PATCH 0/4] i2c: document DMA handling and add helpers for it Wolfram Sang
2017-06-15 18:30 ` [PATCH 1/4] i2c: add helpers to ease DMA handling Wolfram Sang
2017-06-15 20:31 ` Geert Uytterhoeven
2017-06-27 21:16 ` Wolfram Sang [this message]
2017-06-15 18:30 ` [PATCH 2/4] i2c: add docs to clarify " Wolfram Sang
2017-06-15 20:30 ` Geert Uytterhoeven
2017-06-15 18:30 ` [PATCH 3/4] i2c: sh_mobile: use helper to decide if DMA is useful Wolfram Sang
2017-06-15 18:30 ` [PATCH 4/4] i2c: rcar: check for DMA-capable buffers Wolfram Sang
2017-06-15 18:48 ` Shuah Khan
2017-06-15 19:17 ` Wolfram Sang
2017-06-15 19:48 ` Shuah Khan
2017-06-15 18:42 ` [PATCH 0/4] i2c: document DMA handling and add helpers for it Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627211610.53oeludkm3sooo64@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox