From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, wsa@the-dreams.de, robh+dt@kernel.org,
mark.rutland@arm.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] iio: srf08: add buffered to device mode
Date: Sat, 12 Aug 2017 13:02:08 +0100 [thread overview]
Message-ID: <20170812130208.2ed84b76@archlinux> (raw)
In-Reply-To: <20170802232609.GA15406@arbeit>
On Thu, 3 Aug 2017 01:26:09 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> Add INDIO_BUFFER_TRIGGERED and INDIO_BUFFER_SOFTWARE to device mode
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> drivers/iio/proximity/srf08.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index a63c272c3b22..ea238ab1066c 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -437,7 +437,9 @@ static int srf08_probe(struct i2c_client *client,
>
> indio_dev->name = id->name;
> indio_dev->dev.parent = &client->dev;
> - indio_dev->modes = INDIO_DIRECT_MODE;
> + indio_dev->modes = INDIO_DIRECT_MODE
> + | INDIO_BUFFER_TRIGGERED
Huh.? Firstly I think only one of these is relevant and secondly
should be merged back into the original patch that added the support.
Also the triggered_buffer setup already set it for you...
So all in all, drop this patch.
Jonathan
> + | INDIO_BUFFER_SOFTWARE;
>
> /* srf02 is not using sensitivity nor max_range */
> if (id->driver_data == SRF02)
prev parent reply other threads:[~2017-08-12 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 23:26 [PATCH 6/7] iio: srf08: add buffered to device mode Andreas Klinger
2017-08-12 12:02 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812130208.2ed84b76@archlinux \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).