* [PATCH 6/7] iio: srf08: add buffered to device mode
@ 2017-08-02 23:26 Andreas Klinger
2017-08-12 12:02 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Klinger @ 2017-08-02 23:26 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, linux-iio
Cc: wsa, robh+dt, mark.rutland, linux-i2c, devicetree, linux-kernel
Add INDIO_BUFFER_TRIGGERED and INDIO_BUFFER_SOFTWARE to device mode
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
drivers/iio/proximity/srf08.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
index a63c272c3b22..ea238ab1066c 100644
--- a/drivers/iio/proximity/srf08.c
+++ b/drivers/iio/proximity/srf08.c
@@ -437,7 +437,9 @@ static int srf08_probe(struct i2c_client *client,
indio_dev->name = id->name;
indio_dev->dev.parent = &client->dev;
- indio_dev->modes = INDIO_DIRECT_MODE;
+ indio_dev->modes = INDIO_DIRECT_MODE
+ | INDIO_BUFFER_TRIGGERED
+ | INDIO_BUFFER_SOFTWARE;
/* srf02 is not using sensitivity nor max_range */
if (id->driver_data == SRF02)
--
2.1.4
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/7] iio: srf08: add buffered to device mode
2017-08-02 23:26 [PATCH 6/7] iio: srf08: add buffered to device mode Andreas Klinger
@ 2017-08-12 12:02 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-08-12 12:02 UTC (permalink / raw)
To: Andreas Klinger
Cc: knaack.h, lars, pmeerw, linux-iio, wsa, robh+dt, mark.rutland,
linux-i2c, devicetree, linux-kernel
On Thu, 3 Aug 2017 01:26:09 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> Add INDIO_BUFFER_TRIGGERED and INDIO_BUFFER_SOFTWARE to device mode
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> drivers/iio/proximity/srf08.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index a63c272c3b22..ea238ab1066c 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -437,7 +437,9 @@ static int srf08_probe(struct i2c_client *client,
>
> indio_dev->name = id->name;
> indio_dev->dev.parent = &client->dev;
> - indio_dev->modes = INDIO_DIRECT_MODE;
> + indio_dev->modes = INDIO_DIRECT_MODE
> + | INDIO_BUFFER_TRIGGERED
Huh.? Firstly I think only one of these is relevant and secondly
should be merged back into the original patch that added the support.
Also the triggered_buffer setup already set it for you...
So all in all, drop this patch.
Jonathan
> + | INDIO_BUFFER_SOFTWARE;
>
> /* srf02 is not using sensitivity nor max_range */
> if (id->driver_data == SRF02)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-12 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-02 23:26 [PATCH 6/7] iio: srf08: add buffered to device mode Andreas Klinger
2017-08-12 12:02 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).