From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: core: Make comment about I2C table requirement to reflect the code
Date: Mon, 14 Aug 2017 21:34:23 +0200 [thread overview]
Message-ID: <20170814193423.er7hpbxpddztltwp@ninjato> (raw)
In-Reply-To: <20170809092128.29202-1-javierm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Wed, Aug 09, 2017 at 11:21:28AM +0200, Javier Martinez Canillas wrote:
> I2C drivers were required to have an I2C device ID table even if were for
> devices that would only be registered using a specific firmware interface
> (e.g: OF or ACPI).
>
> But commit da10c06a044b ("i2c: Make I2C ID tables non-mandatory for DT'ed
> devices") changed the I2C core to relax the requirement and allow drivers
> to avoid defining this table.
>
> Unfortunately it only took into account drivers for OF-only devices and
> forgot about ACPI-only ones, and this was fixed by commit c64ffff7a9d1
> ("i2c: core: Allow empty id_table in ACPI case as well").
>
> But the latter didn't update the original comment, so it doesn't reflect
> what the code does now.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-14 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 9:21 [PATCH] i2c: core: Make comment about I2C table requirement to reflect the code Javier Martinez Canillas
2017-08-14 19:34 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814193423.er7hpbxpddztltwp@ninjato \
--to=wsa@the-dreams.de \
--cc=javierm@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox