From: Wolfram Sang <wsa@the-dreams.de>
To: Jun Gao <jun.gao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
Date: Mon, 14 Aug 2017 21:47:13 +0200 [thread overview]
Message-ID: <20170814194713.c6ojqcbi2iluayau@ninjato> (raw)
In-Reply-To: <1502674616.930.74.camel@mhfsdcap03>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Mon, Aug 14, 2017 at 09:36:56AM +0800, Jun Gao wrote:
> On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > > + .max_num_msgs = 255,
> > > + .max_write_len = 65535,
> > > + .max_read_len = 65535,
> > > + .max_comb_1st_msg_len = 65535,
> > > + .max_comb_2nd_msg_len = 65535,
> > > +};
> >
> > That looks like no quirks? Then just leave the quirks pointer below
> > empty.
> >
> Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.
I see. But you can safely drop all the length settings. The i2c core has
this comment in quirk handling:
/* Check if val is exceeding the quirk IFF quirk is non 0 */
IFF means "if and only if".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-14 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 2:57 [PATCH v2 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-12 2:57 ` [PATCH v2 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-12 2:57 ` [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
[not found] ` <1502506672-7620-3-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-12 14:44 ` Wolfram Sang
2017-08-14 1:36 ` Jun Gao
2017-08-14 19:47 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814194713.c6ojqcbi2iluayau@ninjato \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=jun.gao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox