From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Luis Oliveira <Luis.Oliveira@synopsys.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table
Date: Wed, 16 Aug 2017 15:41:12 +0200 [thread overview]
Message-ID: <20170816134112.GA1391@katana> (raw)
In-Reply-To: <1b2335bb-50e5-5664-0e01-38902cf717f1@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
> What kind of change are you looking for? The example was introduced by commit
> 04606ccc84e3 ("i2c: designware: introducing I2C_SLAVE definitions") that says:
>
> - A example was added to designware-core.txt Documentation that shows
> how the slave can be setup using DTS
My fault, I missed it :(
> So I could change this example to instead use a real EEPROM compatible (e.g:
> "microchip,24c02") instead of "linux,slave-24c02". Would that be correct?
I think this is Luis call how he'd like this to be changed. Given the
current discussion, I'd think it must be dropped entirely.
Luis?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-16 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 10:12 [PATCH] i2c: slave-eeprom: Add an OF device ID table Javier Martinez Canillas
2017-08-14 19:52 ` Wolfram Sang
2017-08-16 9:36 ` Javier Martinez Canillas
2017-08-16 13:41 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816134112.GA1391@katana \
--to=wsa@the-dreams.de \
--cc=Luis.Oliveira@synopsys.com \
--cc=javierm@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).