From: Wolfram Sang <wsa@the-dreams.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>
Subject: Re: [PATCH 1/2] i2c: designware: Remove needless pm_runtime_put_noidle() call
Date: Thu, 17 Aug 2017 17:57:08 +0200 [thread overview]
Message-ID: <20170817155708.iakoglf7qrdf66bc@ninjato> (raw)
In-Reply-To: <20170815143445.26167-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
On Tue, Aug 15, 2017 at 05:34:44PM +0300, Jarkko Nikula wrote:
> I guess pm_runtime_put_noidle() call in i2c_dw_probe_slave() was copied
> by accident from similar master mode adapter registration code. It is
> unbalanced due missing pm_runtime_get_noresume() but harmless since it
> doesn't decrease dev->power.usage_count below zero.
>
> In theory we can hit similar needless runtime suspend/resume cycle
> during slave mode adapter registration that was happening when
> registering the master mode adapter. See commit cd998ded5c12 ("i2c:
> designware: Prevent runtime suspend during adapter registration").
>
> However, since we are slave, we can consider it as a wrong configuration
> if we have other slaves attached under this adapter and can omit the
> pm_runtime_get_noresume()/pm_runtime_put_noidle() calls for simplicity.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-current, thanks! Not really a bugfix, but 2/2 is, so,
well... BTW, Luis, are you still there? Holiday season?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-17 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:34 [PATCH 1/2] i2c: designware: Remove needless pm_runtime_put_noidle() call Jarkko Nikula
2017-08-15 14:34 ` [PATCH 2/2] i2c: designware: Fix runtime PM for I2C slave mode Jarkko Nikula
2017-08-17 15:57 ` Wolfram Sang
2017-08-17 15:57 ` Wolfram Sang [this message]
2017-09-08 10:23 ` [PATCH 1/2] i2c: designware: Remove needless pm_runtime_put_noidle() call Luis Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817155708.iakoglf7qrdf66bc@ninjato \
--to=wsa@the-dreams.de \
--cc=Luis.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).