From: Wolfram Sang <wsa@the-dreams.de>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: jdelvare@suse.com, tony.luck@intel.com,
mika.westerberg@intel.com, bp@alien8.de,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/1] i2c: i801: Restore the presence state of P2SB PCI device after reading BAR
Date: Thu, 17 Aug 2017 18:05:58 +0200 [thread overview]
Message-ID: <20170817160557.dvhvkoprszbehos5@ninjato> (raw)
In-Reply-To: <20170814160450.21978-1-qiuxu.zhuo@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
On Tue, Aug 15, 2017 at 12:04:50AM +0800, Qiuxu Zhuo wrote:
> Sun, Yunying reported the following failure on Denverton micro-server:
>
> EDAC DEBUG: pnd2_init:
> EDAC DEBUG: pnd2_probe:
> EDAC DEBUG: dnv_rd_reg: Read b_cr_tolud_pci=00000000_80000000
> EDAC DEBUG: dnv_rd_reg: Read b_cr_touud_lo_pci=00000000_80000000
> EDAC DEBUG: dnv_rd_reg: Read b_cr_touud_hi_pci=00000000_00000004
> EDAC DEBUG: dnv_rd_reg: Read b_cr_asym_mem_region0_mchbar=00000000_00000000
> EDAC DEBUG: dnv_rd_reg: Read b_cr_asym_mem_region1_mchbar=00000000_00000000
> EDAC DEBUG: dnv_rd_reg: Read b_cr_mot_out_base_mchbar=00000000_00000000
> EDAC DEBUG: dnv_rd_reg: Read b_cr_mot_out_mask_mchbar=00000000_00000000
> EDAC pnd2: Failed to register device with error -19.
>
> On Denverton micro-server, the presence of the P2SB bridge PCI device is
> enabled or disabled by the item 'RelaxSecConf' in BIOS setup menu. When
> 'RelaxSecConf' is enabled, the P2SB PCI device is present and the pnd2_edac
> EDAC driver also uses it to get BAR. Hiding the P2SB PCI device caused the
> pnd2_edac EDAC driver failed to get BAR then reported the above failure.
>
> Therefor, store the presence state of P2SB PCI device before unhiding it
> for reading BAR and restore the presence state after reading BAR.
>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> Reported-and-tested-by: Yunying Sun <yunying.sun@intel.com>
Looks good to me, but I'll give Jean a chance to comment...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-17 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:04 [PATCH 1/1] i2c: i801: Restore the presence state of P2SB PCI device after reading BAR Qiuxu Zhuo
2017-08-15 7:13 ` Mika Westerberg
2017-08-17 16:05 ` Wolfram Sang [this message]
2017-08-22 8:48 ` Zhuo, Qiuxu
2017-08-28 15:33 ` Wolfram Sang
2017-08-29 1:13 ` Zhuo, Qiuxu
2017-10-13 13:01 ` Jean Delvare
2017-10-16 5:31 ` Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817160557.dvhvkoprszbehos5@ninjato \
--to=wsa@the-dreams.de \
--cc=bp@alien8.de \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox