linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Radu Rendec <radu.rendec@gmail.com>
To: linux-i2c@vger.kernel.org
Cc: Radu Rendec <radu.rendec@gmail.com>
Subject: [PATCH 2/2] i2c: ismt: dump registers at the end of transactions
Date: Fri, 18 Aug 2017 17:01:28 +0100	[thread overview]
Message-ID: <20170818160128.21228-3-radu.rendec@gmail.com> (raw)
In-Reply-To: <20170818160128.21228-1-radu.rendec@gmail.com>

This patch dumps general and master registers at the end of transactions
when debugging is enabled. Previously, registers were only dumped before
submitting new descriptors (at the beginning of transactions).

This helps debugging if some registers change as result of a failed
transaction (e.g. bits are set in the ERRSTS general register).

Signed-off-by: Radu Rendec <radu.rendec@gmail.com>
---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index ccce0ca..003ea53 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -324,6 +324,8 @@ static int ismt_process_desc(const struct ismt_desc *desc,
 
 	dev_dbg(&priv->pci_dev->dev, "Processing completed descriptor\n");
 	__ismt_desc_dump(&priv->pci_dev->dev, desc);
+	ismt_gen_reg_dump(priv);
+	ismt_mstr_reg_dump(priv);
 
 	if (desc->status & ISMT_DESC_SCS) {
 		if (read_write == I2C_SMBUS_WRITE &&
-- 
2.9.5

  parent reply	other threads:[~2017-08-18 16:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 16:01 [PATCH 0/2] i2c: ismt: align the DMA buffer to avoid parity errors Radu Rendec
2017-08-18 16:01 ` [PATCH 1/2] i2c: ismt: 16-byte align the DMA buffer address Radu Rendec
2017-08-27 14:37   ` Wolfram Sang
2017-08-29 16:37     ` radu.rendec
2018-01-04 13:46   ` [1/2] " Neil Horman
2018-01-04 15:42     ` Radu Rendec
2018-01-04 16:22       ` Neil Horman
2018-01-04 17:01         ` Radu Rendec
2018-01-05  1:47           ` Neil Horman
2018-01-15 12:33             ` Radu Rendec
2018-01-15 18:53               ` Neil Horman
2018-01-15 19:02                 ` Wolfram Sang
2018-01-15 19:53                   ` Neil Horman
2017-08-18 16:01 ` Radu Rendec [this message]
2018-01-04 13:52   ` [2/2] i2c: ismt: dump registers at the end of transactions Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818160128.21228-3-radu.rendec@gmail.com \
    --to=radu.rendec@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).