From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for named gpios Date: Mon, 28 Aug 2017 10:16:52 +0200 Message-ID: <20170828081651.GF22421@verge.net.au> References: <1503566474-5335-1-git-send-email-geert+renesas@glider.be> <1503566474-5335-2-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1503566474-5335-2-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Wolfram Sang , Rob Herring , Mark Rutland , Haavard Skinnemoen , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thu, Aug 24, 2017 at 11:21:12AM +0200, Geert Uytterhoeven wrote: > The current i2c-gpio DT bindings use a single unnamed "gpios" property > to refer to the SDA and SCL signal lines by index. This is error-prone > for the casual DT writer and reviewer, as one has to look up the order > in the DT bindings. > > Fix this by amending the DT bindings to use two separate named gpios > properties, and deprecate the old unnamed variant. > > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt > index 4f8ec947c6bd9cad..61033f73577dd70e 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt > @@ -2,8 +2,9 @@ Device-Tree bindings for i2c gpio driver > > Required properties: > - compatible = "i2c-gpio"; > - - gpios: sda and scl gpio > - > + - sda-gpios: gpio used for the sda signal > + - scl-gpios: gpio used for the scl signal > + - gpios: sda and scl gpio, alternative for {sda,scl}-gpios (deprecated) > > Optional properties: > - i2c-gpio,sda-open-drain: sda as open drain Maybe it would be best to update the example too? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html