linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Sebastian Reichel <sre@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	Liam Breck <liam@networkimprov.net>,
	Tony Lindgren <tony@atomide.com>,
	linux-pm@vger.kernel.org, devel@driverdev.osuosl.org
Subject: [PATCH v3 02/11] staging: typec: tcpm: Add get_current_limit tcpc_dev callback
Date: Wed, 30 Aug 2017 11:48:05 +0200	[thread overview]
Message-ID: <20170830094814.17758-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20170830094814.17758-1-hdegoede@redhat.com>

A Rp signalling the default current limit indicates that we're possibly
connected to an USB2 power-source. In some cases the type-c port-controller
may provide the capability to detect the current-limit in this case,
through e.g. BC1.2 detection.

This commit adds an optional get_current_limit tcpc_dev callback which
allows the port-controller to provide current-limit detection for when
the CC pin is pulled up with Rp.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Changes in v2:
-s/get_usb2_current_limit/get_current_limit/
---
 drivers/staging/typec/tcpm.c | 5 ++++-
 drivers/staging/typec/tcpm.h | 7 +++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index a911cad41a59..6ca73a3c7e88 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers/staging/typec/tcpm.c
@@ -667,7 +667,10 @@ static u32 tcpm_get_current_limit(struct tcpm_port *port)
 		break;
 	case TYPEC_CC_RP_DEF:
 	default:
-		limit = 0;
+		if (port->tcpc->get_current_limit)
+			limit = port->tcpc->get_current_limit(port->tcpc);
+		else
+			limit = 0;
 		break;
 	}
 
diff --git a/drivers/staging/typec/tcpm.h b/drivers/staging/typec/tcpm.h
index 374cea44a84a..7e9a6b7b5cd6 100644
--- a/drivers/staging/typec/tcpm.h
+++ b/drivers/staging/typec/tcpm.h
@@ -109,6 +109,13 @@ struct tcpc_dev {
 
 	int (*init)(struct tcpc_dev *dev);
 	int (*get_vbus)(struct tcpc_dev *dev);
+	/*
+	 * This optional callback gets called by the tcpm core when configured
+	 * as a snk and cc=Rp-def. This allows the tcpm to provide a fallback
+	 * current-limit detection method for the cc=Rp-def case. E.g. some
+	 * tcpcs may include BC1.2 charger detection and use that in this case.
+	 */
+	int (*get_current_limit)(struct tcpc_dev *dev);
 	int (*set_cc)(struct tcpc_dev *dev, enum typec_cc_status cc);
 	int (*get_cc)(struct tcpc_dev *dev, enum typec_cc_status *cc1,
 		      enum typec_cc_status *cc2);
-- 
2.13.4

  parent reply	other threads:[~2017-08-30  9:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  9:48 [PATCH v3 00/11] Hookup typec power-negotation to the PMIC and charger Hans de Goede
2017-08-30  9:48 ` [PATCH v3 01/11] i2c: Allow overriding dev_name through board_info Hans de Goede
2017-08-30  9:48 ` Hans de Goede [this message]
2017-08-30  9:48 ` [PATCH v3 03/11] staging: typec: fusb302: Set max supply voltage to 5V Hans de Goede
2017-08-30 13:37   ` Guenter Roeck
2017-08-30  9:48 ` [PATCH v3 04/11] staging: typec: fusb302: Get max snk mv/ma/mw from device-properties Hans de Goede
2017-08-30 13:50   ` Guenter Roeck
2017-08-30  9:48 ` [PATCH v3 05/11] staging: typec: fusb302: Use client->irq as irq if set Hans de Goede
2017-08-30 13:56   ` Guenter Roeck
2017-08-30  9:48 ` [PATCH v3 06/11] staging: typec: fusb302: Add support for USB2 charger detection through extcon Hans de Goede
2017-08-30 13:58   ` Guenter Roeck
2017-08-30  9:48 ` [PATCH v3 07/11] staging: typec: fusb302: Export current-limit through a power_supply class dev Hans de Goede
2017-08-30 14:01   ` Guenter Roeck
2017-08-30  9:48 ` [PATCH v3 08/11] power: supply: bq24190_charger: Export 5V boost converter as regulator Hans de Goede
2017-08-30 14:46   ` Tony Lindgren
2017-08-30 16:32     ` Sebastian Reichel
2017-08-30  9:48 ` [PATCH v3 09/11] power: supply: bq24190_charger: Get input_current_limit from our supplier Hans de Goede
2017-08-30 14:47   ` Tony Lindgren
2017-08-30 16:32     ` Sebastian Reichel
2017-08-30  9:48 ` [PATCH v3 10/11] i2c-cht-wc: Add device-properties for fusb302 integration Hans de Goede
2017-08-30  9:48 ` [PATCH v3 11/11] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties Hans de Goede
2017-08-31 16:26 ` [PATCH v3 00/11] Hookup typec power-negotation to the PMIC and charger Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830094814.17758-3-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@infradead.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=liam@networkimprov.net \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).