From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [RFT][PATCH v2 2/2] PM / i2c: designware: Clean up system sleep handling without ACPI Date: Tue, 5 Sep 2017 17:58:35 +0300 Message-ID: <20170905145835.GZ2477@lahna.fi.intel.com> References: <3023226.l5IfJK6GIc@aspire.rjw.lan> <1729594.8Da7J7iljp@aspire.rjw.lan> <20170905144511.GX2477@lahna.fi.intel.com> <3930469.chvfik16I5@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3930469.chvfik16I5@aspire.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org, Wolfram Sang , linux-acpi@vger.kernel.org, Kevin Hilman , Jarkko Nikula , Andy Shevchenko , Jisheng Zhang , John Stultz , Guodong Xu , Sumit Semwal , Haojian Zhuang , Johannes Stezenbach , Ulf Hansson List-Id: linux-i2c@vger.kernel.org On Tue, Sep 05, 2017 at 04:46:11PM +0200, Rafael J. Wysocki wrote: > On Tuesday, September 5, 2017 4:45:11 PM CEST Mika Westerberg wrote: > > On Mon, Sep 04, 2017 at 12:01:54PM +0200, Rafael J. Wysocki wrote: > > > static const struct dev_pm_ops dw_i2c_dev_pm_ops = { > > > - .prepare = dw_i2c_plat_prepare, > > > - .complete = dw_i2c_plat_complete, > > > - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) > > > - SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, > > > - dw_i2c_plat_resume, > > > - NULL) > > > + SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) > > > > This seems to cause problem with intel-lpss MFD driver because it uses > > .suspend() and .resume() instead of .suspend_late() and .resume_early(). > > OK, so there is one more dependency here. > > Can you please point me to this code? It is in drivers/mfd/intel-lpss.c. See intel_lpss_resume().