From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/7] i2c: gpio: Convert to use descriptors Date: Mon, 18 Sep 2017 09:36:29 +0100 Message-ID: <20170918083629.qn4dlrmk7ffipfsz@dell> References: <20170917093906.16325-1-linus.walleij@linaro.org> <20170917093906.16325-2-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f174.google.com ([209.85.128.174]:47993 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdIRIgd (ORCPT ); Mon, 18 Sep 2017 04:36:33 -0400 Received: by mail-wr0-f174.google.com with SMTP id k20so5575222wre.4 for ; Mon, 18 Sep 2017 01:36:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170917093906.16325-2-linus.walleij@linaro.org> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Linus Walleij Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, adi-buildroot-devel@lists.sourceforge.net, Geert Uytterhoeven , Steven Miao , Ralf Baechle , Guenter Roeck , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Magnus Damm , Ben Dooks , Heiko Schocher On Sun, 17 Sep 2017, Linus Walleij wrote: > This converts the GPIO-based I2C-driver to using GPIO > descriptors instead of the old global numberspace-based > GPIO interface. We: [STUFF] > - The MFD Silicon Motion SM501 is a special case. It dynamically > spawns an I2C bus off the MFD using sm501_create_subdev(). > We use an approach to dynamically create a machine descriptor > table and attach this to the "SM501-LOW" or "SM501-HIGH" > gpiochip. We use chip-local offsets to grab the right lines. > We can get rid of two local static inline helpers as part > of this refactoring. > > Cc: Steven Miao > Cc: Ralf Baechle > Cc: Lee Jones > Cc: Guenter Roeck > Cc: Ville Syrjälä > Cc: Magnus Damm > Cc: Ben Dooks > Cc: Heiko Schocher > Acked-by: Olof Johansson > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Fix a minor typo in error path (scl was sda from copy-paste) > - Collected Olof's ACK > > Steven (Blackfin): requesting ACK for Wolfram to take this patch. > Ralf (MIPS): requesting ACK for Wolfram to take this patch. > Lee: requesting ACK for Wolfram to take this patch. This ... > SM501 users: requesting Tested-by on this patch. ... loosely depends on this (until it doesn't). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog