public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Rajat Jain <rajatja@google.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
	furquan@google.com, rajatxjain@gmail.com
Cc: Rajat Jain <rajatja@google.com>
Subject: [PATCH 2/2] mfd: intel-lpss: switch to suspend_late()/resume_early()
Date: Wed, 20 Sep 2017 15:31:52 -0700	[thread overview]
Message-ID: <20170920223152.100641-2-rajatja@google.com> (raw)
In-Reply-To: <20170920223152.100641-1-rajatja@google.com>

Ref: https://lkml.org/lkml/2017/9/19/649

The intel-lpss hosts the designware i2c controller device, which
needs to be up and running until all its i2c child devices have
suspended (child devices need to be accessible over i2c until
suspend_late() has been called for all those devices).

So lets delay the resetting of the controller until suspend_late().
I thought of renaming function to say *_late / *_early but that
might cause confusion since the same function is also used for runtime
suspend/resume.

Fixes: 0b471aaa0e1a ("Put I2C and SPI controllers into reset state on suspend")
Signed-off-by: Rajat Jain <rajatja@google.com>
---
 drivers/mfd/intel-lpss.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
index 694116630ffa..865bbeaaf00c 100644
--- a/drivers/mfd/intel-lpss.h
+++ b/drivers/mfd/intel-lpss.h
@@ -38,12 +38,7 @@ int intel_lpss_resume(struct device *dev);
 #ifdef CONFIG_PM_SLEEP
 #define INTEL_LPSS_SLEEP_PM_OPS			\
 	.prepare = intel_lpss_prepare,		\
-	.suspend = intel_lpss_suspend,		\
-	.resume = intel_lpss_resume,		\
-	.freeze = intel_lpss_suspend,		\
-	.thaw = intel_lpss_resume,		\
-	.poweroff = intel_lpss_suspend,		\
-	.restore = intel_lpss_resume,
+	SET_LATE_SYSTEM_SLEEP_PM_OPS(intel_lpss_suspend, intel_lpss_resume)
 #else
 #define INTEL_LPSS_SLEEP_PM_OPS
 #endif
-- 
2.14.1.821.g8fa685d3b7-goog

  reply	other threads:[~2017-09-20 22:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 22:31 [PATCH 1/2] i2c: designware: switch to suspend_late/resume_early Rajat Jain
2017-09-20 22:31 ` Rajat Jain [this message]
2017-09-21  0:27   ` [PATCH 2/2] mfd: intel-lpss: switch to suspend_late()/resume_early() Rafael J. Wysocki
2017-09-21  1:14     ` Rajat Jain
2017-09-21  8:41     ` Lee Jones
2017-09-21 14:10       ` Rafael J. Wysocki
2017-09-21 15:17         ` Lee Jones
2017-09-21 15:18           ` Rafael J. Wysocki
2017-09-20 22:42 ` [PATCH 1/2] i2c: designware: switch to suspend_late/resume_early Rajat Jain
2017-09-21  0:24 ` Rafael J. Wysocki
2017-09-21  1:13   ` Rajat Jain
2017-09-21 14:11     ` Rafael J. Wysocki
2017-09-23 12:55       ` Rafael J. Wysocki
2017-09-23 15:49         ` Rajat Jain
2017-09-23 16:17           ` Rajat Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920223152.100641-2-rajatja@google.com \
    --to=rajatja@google.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=furquan@google.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=len.brown@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rajatxjain@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox