From: Wolfram Sang <wsa@the-dreams.de>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Jean Delvare <jdelvare@suse.de>,
linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] i2c: piix4: Disable completely the IMC during SMBUS_BLOCK_DATA
Date: Fri, 13 Oct 2017 21:04:15 +0200 [thread overview]
Message-ID: <20171013190415.c6dqyjnhm6jwcmpo@ninjato> (raw)
In-Reply-To: <20171013190326.gozfjhmv2pbmnrgt@ninjato>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Fri, Oct 13, 2017 at 09:03:26PM +0200, Wolfram Sang wrote:
> On Tue, Oct 10, 2017 at 06:11:15PM +0200, Ricardo Ribalda Delgado wrote:
> > SMBUS_BLOCK_DATA transactions might fail due to a race condition with
> > the IMC (Integrated Micro Controller), even when the IMC semaphore
> > is used.
> >
> > This bug has been reported and confirmed by AMD, who suggested as a
> > solution an IMC firmware upgrade (obtained via BIOS update) and
> > disabling the IMC during SMBUS_BLOCK_DATA transactions.
> >
> > Even without the IMC upgrade, the SMBUS is much more stable with this
> > patch.
> >
> > Tested on a Bettong-alike board.
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>
> Applied to for-current, thanks!
But please mention the dependency next time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-13 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 16:11 [PATCH v3] i2c: piix4: Disable completely the IMC during SMBUS_BLOCK_DATA Ricardo Ribalda Delgado
2017-10-10 18:28 ` Jean Delvare
2017-10-13 18:52 ` Wolfram Sang
2017-10-13 19:03 ` Wolfram Sang
2017-10-13 19:04 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013190415.c6dqyjnhm6jwcmpo@ninjato \
--to=wsa@the-dreams.de \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).