From: Wolfram Sang <wsa@the-dreams.de>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v6] eeprom: at24: Add OF device ID table
Date: Tue, 17 Oct 2017 23:40:40 +0200 [thread overview]
Message-ID: <20171017214040.kak3kpvh6tunjjfp@ninjato> (raw)
In-Reply-To: <20171001104948.21663-1-javierm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
Hi,
> + {
> + .compatible = "atmel,spd",
> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8,
> + AT24_FLAG_READONLY | AT24_FLAG_IRUGO)
> + },
checkpatch reported this one as un-documented. And come to think of it,
since this is solely for EEPROMs on RAM modules, I think we can drop a
DT binding for it. Could you agree? I can do it locally, no need to
resend. I'll do HW testing later, but wanted to check on your opinion
already.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-17 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 10:49 [PATCH v6] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-10-17 21:40 ` Wolfram Sang [this message]
2017-10-17 21:43 ` Rob Herring
2017-10-17 21:47 ` Wolfram Sang
2017-10-18 6:39 ` Geert Uytterhoeven
2017-10-18 18:51 ` Javier Martinez Canillas
2017-11-05 21:53 ` Wolfram Sang
2017-11-06 9:13 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017214040.kak3kpvh6tunjjfp@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=javierm@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).