From: Wolfram Sang <wsa@the-dreams.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties
Date: Fri, 27 Oct 2017 12:41:27 +0200 [thread overview]
Message-ID: <20171027104126.iaoandrsng7hxehq@ninjato> (raw)
In-Reply-To: <011c294b-20c3-9c37-3606-626b2201fde9@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]
On Fri, Oct 27, 2017 at 12:31:01PM +0200, Hans de Goede wrote:
> Hi,
>
> On 27-10-17 12:13, Hans de Goede wrote:
> > Hi,
> >
> > On 26-10-17 22:33, Wolfram Sang wrote:
> > > On Wed, Oct 11, 2017 at 11:41:21AM +0200, Hans de Goede wrote:
> > > > The fusb302 driver as merged in staging uses "typec_fusb302" as i2c-id
> > > > rather then just "fusb302" and needs us to set a number of device-
> > > > properties, adjust the intel_cht_int33fe driver accordingly.
> > > >
> > > > One of the properties set is max-snk-mv which makes the fusb302 driver
> > > > negotiate up to 12V charging voltage, which is a bad idea on boards
> > > > which are not setup to handle this, so this commit also adds 2 extra
> > > > sanity checks to make sure that the expected Whiskey Cove PMIC +
> > > > TI bq24292i charger combo, which can handle 12V, is present.
> > > >
> > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > > > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >
> > > I can't apply this one. Is there an immutable branch I need to pick up?
> > > Or shall this go via another tree? My base is v4.14-rc5.
> >
> > It should be applied on top of this patch:
> >
> > http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/commitdiff/5c003458db40cf3c89aeddd22c6e934c28b5a565
> >
> > From linux-platform-drivers-x86.git/for-next.
> >
> > So either we are going to need an immutable branch from you
> > with the first patch of this series so that the platform/x86
> > maintainers can merge this, or the other way around :|
>
> Alternatively we could push this patch as a post rc1 fix I guess.
I intentionally did not push out yet until this was cleared. So, I think
the most simple option is that I create an immutable branch with only
the i2c patches from you. Then linux-platform maintainers can pull in
my branch and your patch here on top of that. Would be my favourite.
D'accord everyone?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-27 10:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 9:41 [PATCH v5 0/3] i2c: Hookup typec power-negotation to the PMIC and charger Hans de Goede
2017-10-11 9:41 ` [PATCH resend v5 1/3] i2c: Allow overriding dev_name through board_info Hans de Goede
2017-10-26 20:29 ` Wolfram Sang
2017-10-11 9:41 ` [PATCH resend v5 2/3] i2c-cht-wc: Add device-properties for fusb302 integration Hans de Goede
2017-10-26 20:30 ` Wolfram Sang
2017-10-11 9:41 ` [PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties Hans de Goede
2017-10-26 20:33 ` Wolfram Sang
2017-10-27 10:13 ` Hans de Goede
2017-10-27 10:31 ` Hans de Goede
2017-10-27 10:41 ` Wolfram Sang [this message]
2017-10-27 15:24 ` Hans de Goede
2017-11-03 11:55 ` Andy Shevchenko
2017-10-14 10:45 ` [PATCH v5 0/3] i2c: Hookup typec power-negotation to the PMIC and charger Andy Shevchenko
2017-10-14 12:04 ` Hans de Goede
2017-10-19 14:42 ` Wolfram Sang
2017-10-19 14:54 ` Hans de Goede
2017-10-20 16:36 ` Andy Shevchenko
2017-10-21 8:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027104126.iaoandrsng7hxehq@ninjato \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox