From: Wolfram Sang <wsa@the-dreams.de>
To: Ed Blake <ed.blake@sondrel.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: img-scb: Add runtime PM
Date: Fri, 27 Oct 2017 22:04:30 +0200 [thread overview]
Message-ID: <20171027200429.cq565fpkedc7luls@ninjato> (raw)
In-Reply-To: <1506937741-32748-1-git-send-email-ed.blake@sondrel.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On Mon, Oct 02, 2017 at 10:49:01AM +0100, Ed Blake wrote:
> The i2c-img-scb driver already dynamically enables / disables clocks to
> save power, but doesn't use the runtime PM framework. Convert the
> driver to use runtime PM, so that dynamic clock management will be
> disabled when runtime PM is disabled, and so that autosuspend can be
> used to avoid unnecessarily disabling and re-enabling clocks repeatedly
> during a sequence of transactions.
>
> Signed-off-by: Ed Blake <ed.blake@sondrel.com>
I get on build-testing:
drivers/i2c/busses/i2c-img-scb.c:1164:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-27 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 9:49 [PATCH] i2c: img-scb: Add runtime PM Ed Blake
2017-10-27 20:04 ` Wolfram Sang [this message]
2017-10-28 11:42 ` Ed Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027200429.cq565fpkedc7luls@ninjato \
--to=wsa@the-dreams.de \
--cc=ed.blake@sondrel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox