From: Wolfram Sang <wsa@the-dreams.de>
To: Claudio Foellmi <claudio.foellmi@ergon.ch>
Cc: Tony Lindgren <tony@atomide.com>, "Nori, Sekhar" <nsekhar@ti.com>,
"Cooper Jr., Franklin" <fcooper@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH v2] i2c: omap: Trigger bus recovery in lockup case
Date: Sat, 28 Oct 2017 22:52:55 +0200 [thread overview]
Message-ID: <20171028205255.56qryat6eanhwfcz@ninjato> (raw)
In-Reply-To: <1507110225-3050-1-git-send-email-claudio.foellmi@ergon.ch>
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
> + if (!(systest & OMAP_I2C_SYSTEST_SCL_I_FUNC))
> + return -ETIMEDOUT; /* recovery would not fix SCL */
I'd rather return EBUSY here. It is not that the transaction timed out.
If you agree, I can fix it locally, no need to resend.
Rest looks good, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-28 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 15:39 [PATCH] i2c-omap: Trigger bus recovery in lockup case Claudio Foellmi
2017-09-15 23:31 ` Grygorii Strashko
2017-09-18 5:24 ` Vignesh R
2017-09-18 12:01 ` Claudio Foellmi
2017-09-19 10:50 ` Vignesh R
2017-09-20 9:24 ` Claudio Foellmi
2017-09-20 15:02 ` Sebastian Reichel
2017-09-26 12:24 ` Claudio Foellmi
2017-09-29 12:52 ` Sebastian Reichel
2017-09-29 15:17 ` Claudio Foellmi
2017-09-29 16:37 ` Sebastian Reichel
2017-10-02 23:01 ` Grygorii Strashko
2017-10-06 15:22 ` Sebastian Reichel
2017-10-03 10:32 ` Vignesh R
2017-10-04 9:43 ` [PATCH v2] i2c: omap: " Claudio Foellmi
2017-10-05 6:01 ` Vignesh R
2017-10-05 12:30 ` Grygorii Strashko
2017-10-28 20:52 ` Wolfram Sang [this message]
2017-10-30 9:11 ` Claudio Foellmi
2017-10-30 14:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171028205255.56qryat6eanhwfcz@ninjato \
--to=wsa@the-dreams.de \
--cc=aaro.koskinen@iki.fi \
--cc=claudio.foellmi@ergon.ch \
--cc=fcooper@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox