From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-pm@vger.kernel.org, Phil Reid <preid@electromag.com.au>,
sre@kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: [PATCH 2/3] power: supply: sbs-battery: remove unchecked return var
Date: Sun, 29 Oct 2017 16:35:44 +0100 [thread overview]
Message-ID: <20171029153545.3947-3-wsa@the-dreams.de> (raw)
In-Reply-To: <20171029153545.3947-1-wsa@the-dreams.de>
Since the return value is not checked anyhow, we don't need to store it.
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/power/supply/sbs-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
index fb61da370947f4..83d7b4115857e3 100644
--- a/drivers/power/supply/sbs-battery.c
+++ b/drivers/power/supply/sbs-battery.c
@@ -556,7 +556,7 @@ static int sbs_get_battery_serial_number(struct i2c_client *client,
if (ret < 0)
return ret;
- ret = sprintf(sbs_serial, "%04x", ret);
+ sprintf(sbs_serial, "%04x", ret);
val->strval = sbs_serial;
return 0;
--
2.11.0
next prev parent reply other threads:[~2017-10-29 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 15:35 [PATCH 0/3] power: supply: minor improvements to sbs-manager and battery Wolfram Sang
2017-10-29 15:35 ` [PATCH 1/3] power: supply: sbs-battery: remove superfluous variable init Wolfram Sang
2017-10-29 15:35 ` Wolfram Sang [this message]
2017-10-29 15:35 ` [PATCH 3/3] power: supply: sbs-message: fix some code style issues Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029153545.3947-3-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).