From: Wolfram Sang <wsa@the-dreams.de>
To: Joel Stanley <joel@jms.id.au>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Jeffery <andrew@aj.id.au>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: aspeed: Deassert reset in probe
Date: Mon, 30 Oct 2017 15:24:46 +0100 [thread overview]
Message-ID: <20171030142446.rsvytlcfcuhnkhdj@ninjato> (raw)
In-Reply-To: <20171030034438.26482-1-joel@jms.id.au>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
> #include <linux/clk.h>
> #include <linux/completion.h>
> +#include <linux/delay.h>
Sorry, I missed it from previous reviews, but why is delay.h needed?
> + bus->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> + if (IS_ERR(bus->rst)) {
> + dev_err(&pdev->dev, "invalid reset controller in device tree");
> + bus->rst = NULL;
> + } else
> + reset_control_deassert(bus->rst);
checkpatch --strict says:
CHECK: braces {} should be used on all arms of this statement
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-30 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 3:44 [PATCH v3] i2c: aspeed: Deassert reset in probe Joel Stanley
2017-10-30 14:24 ` Wolfram Sang [this message]
2017-10-30 20:05 ` Benjamin Herrenschmidt
2017-10-30 20:12 ` Wolfram Sang
2017-10-30 16:09 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030142446.rsvytlcfcuhnkhdj@ninjato \
--to=wsa@the-dreams.de \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).