From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Reid <preid@electromag.com.au>
Cc: Jean Delvare <jdelvare@suse.de>,
robh+dt@kernel.org, mark.rutland@arm.com, sre@kernel.org,
jdelvare@suse.com, jglauber@cavium.com, david.daney@cavium.com,
peda@axentia.se, benjamin.tissoires@redhat.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v11 02/10] i2c: i2c-smbus: Move i2c_setup_smbus_alert from i2c-smbus to i2c-core-smbus
Date: Tue, 7 Nov 2017 08:22:55 +0100 [thread overview]
Message-ID: <20171107072254.s43mwpyplx3hdkyo@ninjato> (raw)
In-Reply-To: <2eaccb51-62cf-b764-d313-84008c6c8f87@electromag.com.au>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
> I was just thinking that all that's in the file now is smbus-alert code.
> The other smbus (host notify) code was moved to i2c-core
> So maybe i2c-core-smbus-alert and as you say use makefile to include it.
Aaaah, i2c-core-smbus-alert.c. Yes, that probably makes sense. I was
wondering about i2c-smbus-alert.c (without -core)...
> I've tried this and it seems to work for the various combinations.
> I'll wait a bit for Jean to offer an opinion.
Well, if you have code already, can you post it as RFC and CC Jean?
It usually is easier to talk over code, even if it is not perfect yet...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-07 7:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 9:31 [PATCH v11 00/10] Add sbs-manager with smbalert support Phil Reid
2017-08-24 9:31 ` [PATCH v11 01/10] i2c: i2c-smbus: Use threaded irq for smbalert Phil Reid
2017-08-24 9:31 ` [PATCH v11 03/10] i2c: i2c-smbus: add of_i2c_setup_smbus_alert Phil Reid
2017-08-24 9:31 ` [PATCH v11 05/10] i2c: mux: pca954x: call request irq after adding mux segments Phil Reid
[not found] ` <1503567070-115646-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-08-24 9:31 ` [PATCH v11 02/10] i2c: i2c-smbus: Move i2c_setup_smbus_alert from i2c-smbus to i2c-core-smbus Phil Reid
[not found] ` <1503567070-115646-3-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-10-29 15:44 ` Wolfram Sang
2017-10-30 4:23 ` Phil Reid
[not found] ` <1397131b-c22d-9872-dbe0-9b691553cb9e-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-11-06 21:36 ` Wolfram Sang
2017-11-07 1:16 ` Phil Reid
2017-11-07 7:22 ` Wolfram Sang [this message]
2017-11-17 12:15 ` Phil Reid
2017-08-24 9:31 ` [PATCH v11 04/10] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Phil Reid
2017-08-24 9:31 ` [PATCH v11 06/10] i2c: mux: pca954x: Return error if irq_create_mapping fails Phil Reid
2017-08-24 9:31 ` [PATCH v11 08/10] power: Adds support for Smart Battery System Manager Phil Reid
2017-08-24 9:31 ` [PATCH v11 07/10] Documentation: Add sbs-manager device tree node documentation Phil Reid
2017-08-24 9:31 ` [PATCH v11 09/10] power: supply: sbs-manager: Add alert callback and battery change notification Phil Reid
2017-08-24 9:31 ` [PATCH v11 10/10] power: supply: sbs-battery: move gpio present detect to sbs_get_property Phil Reid
2017-09-28 7:38 ` [PATCH v11 00/10] Add sbs-manager with smbalert support Phil Reid
[not found] ` <66235a12-a209-be89-5bfd-dc69b769cab9-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-10-28 22:55 ` Wolfram Sang
2017-10-29 14:37 ` Sebastian Reichel
2017-10-29 15:05 ` Wolfram Sang
2017-11-01 22:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107072254.s43mwpyplx3hdkyo@ninjato \
--to=wsa@the-dreams.de \
--cc=benjamin.tissoires@redhat.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jdelvare@suse.de \
--cc=jglauber@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).