From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Jacopo Mondi <jacopo@jmondi.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [RFT] i2c: sh_mobile: let RuntimePM do the clock handling
Date: Wed, 8 Nov 2017 09:50:37 +0100 [thread overview]
Message-ID: <20171108085037.1318-1-wsa+renesas@sang-engineering.com> (raw)
No need to do it manually.
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
jacopo: can you test this on Migo-R, please, on top of the other I2C patches?
I tested it on a Lager and it worked there. Will try Gen3 later, too.
drivers/i2c/busses/i2c-sh_mobile.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index ebd146ccb24465..80561ffbcf7b46 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -702,7 +702,6 @@ static int sh_mobile_i2c_xfer(struct i2c_adapter *adapter,
/* Wake up device and enable clock */
pm_runtime_get_sync(pd->dev);
- clk_prepare_enable(pd->clk);
/* Process all messages */
for (i = 0; i < num; i++) {
@@ -743,7 +742,6 @@ static int sh_mobile_i2c_xfer(struct i2c_adapter *adapter,
iic_wr(pd, ICCR, 0);
/* Disable clock and mark device as idle */
- clk_disable_unprepare(pd->clk);
pm_runtime_put_sync(pd->dev);
return err ?: num;
--
2.11.0
next reply other threads:[~2017-11-08 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 8:50 Wolfram Sang [this message]
2017-11-08 18:41 ` [RFT] i2c: sh_mobile: let RuntimePM do the clock handling jacopo mondi
2017-11-08 21:07 ` Wolfram Sang
2017-11-27 17:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108085037.1318-1-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox