* [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables
@ 2017-11-10 18:33 Andy Shevchenko
2017-12-28 15:21 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-11-10 18:33 UTC (permalink / raw)
To: Seth Heasley, Neil Horman, Wolfram Sang, linux-i2c; +Cc: Andy Shevchenko
...which takes care of proper format and size of the value.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-ismt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index b51adffa4841..c0d0f34d34f3 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
return -EIO;
}
- dev_dbg(dev, " dma_addr = 0x%016llX\n",
- (unsigned long long)dma_addr);
+ dev_dbg(dev, " dma_addr = %pad\n", &dma_addr);
desc->dptr_low = lower_32_bits(dma_addr);
desc->dptr_high = upper_32_bits(dma_addr);
--
2.14.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables
2017-11-10 18:33 [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables Andy Shevchenko
@ 2017-12-28 15:21 ` Andy Shevchenko
2017-12-30 23:22 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-12-28 15:21 UTC (permalink / raw)
To: Seth Heasley, Neil Horman, Wolfram Sang, linux-i2c
On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote:
> ...which takes care of proper format and size of the value.
Wolfram, any comment on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-ismt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-
> ismt.c
> index b51adffa4841..c0d0f34d34f3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap,
> u16 addr,
> return -EIO;
> }
>
> - dev_dbg(dev, " dma_addr = 0x%016llX\n",
> - (unsigned long long)dma_addr);
> + dev_dbg(dev, " dma_addr = %pad\n", &dma_addr);
>
> desc->dptr_low = lower_32_bits(dma_addr);
> desc->dptr_high = upper_32_bits(dma_addr);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables
2017-12-28 15:21 ` Andy Shevchenko
@ 2017-12-30 23:22 ` Wolfram Sang
2017-12-31 15:48 ` Neil Horman
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2017-12-30 23:22 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Seth Heasley, Neil Horman, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Thu, Dec 28, 2017 at 05:21:51PM +0200, Andy Shevchenko wrote:
> On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote:
> > ...which takes care of proper format and size of the value.
>
> Wolfram, any comment on this?
I was leaving this for the driver maintainers, but well, this is an easy
one, so...
>
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables
2017-12-30 23:22 ` Wolfram Sang
@ 2017-12-31 15:48 ` Neil Horman
2018-01-03 22:00 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Neil Horman @ 2017-12-31 15:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Andy Shevchenko, Seth Heasley, linux-i2c
On Sun, Dec 31, 2017 at 12:22:01AM +0100, Wolfram Sang wrote:
> On Thu, Dec 28, 2017 at 05:21:51PM +0200, Andy Shevchenko wrote:
> > On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote:
> > > ...which takes care of proper format and size of the value.
> >
> > Wolfram, any comment on this?
>
> I was leaving this for the driver maintainers, but well, this is an easy
> one, so...
>
> >
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Applied to for-next, thanks!
>
Sorry for the delay, I was on holiday. FWIW
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-04 2:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-10 18:33 [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables Andy Shevchenko
2017-12-28 15:21 ` Andy Shevchenko
2017-12-30 23:22 ` Wolfram Sang
2017-12-31 15:48 ` Neil Horman
2018-01-03 22:00 ` Wolfram Sang
2018-01-04 2:10 ` Neil Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).