From: Wolfram Sang <wsa@the-dreams.de>
To: Sebastian Reichel <sre@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Karl-Heinz Schneider <karl-heinz@schneider-inet.de>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] power: supply: sbs-message: double left shift bug in sbsm_select()
Date: Mon, 13 Nov 2017 12:02:32 +0100 [thread overview]
Message-ID: <20171113110231.ixxeszux3d7agojv@ninjato> (raw)
In-Reply-To: <20171113105524.xdiusofmau36zdeu@earth>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On Mon, Nov 13, 2017 at 11:55:24AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Nov 07, 2017 at 03:43:22PM +0300, Dan Carpenter wrote:
> > The original code does this: "1 << (1 << 11)" which is undefined in C.
> >
> > Fixes: dbc4deda03fe ("power: Adds support for Smart Battery System Manager")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > From static analysis. Not tested.
> >
> > diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sbs-manager.c
> > index ccb4217b9638..cb6e8f66c7a2 100644
> > --- a/drivers/power/supply/sbs-manager.c
> > +++ b/drivers/power/supply/sbs-manager.c
> > @@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_core *muxc, u32 chan)
> > return ret;
> >
> > /* chan goes from 1 ... 4 */
> > - reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan);
> > + reg = BIT(SBSM_SMB_BAT_OFFSET + chan);
> > ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg);
> > if (ret)
> > dev_err(dev, "Failed to select channel %i\n", chan);
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> sbs-manager has been added to linux-next through the i2c tree due to
> dependencies, so this one also needs to go through i2c.
I want to send Linus my pull request early this time (like today or
tomorrow). So, you either apply this patch then yourself afterwards on
top of linus' tree. Or I send it to him, but then I'd need the original
patch bounced or resent. Both fine with me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-13 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171107124322.mm3fqkrggw3zidrx@mwanda>
2017-11-13 10:55 ` [PATCH] power: supply: sbs-message: double left shift bug in sbsm_select() Sebastian Reichel
2017-11-13 11:02 ` Wolfram Sang [this message]
2017-11-15 7:45 ` Wolfram Sang
2017-11-15 10:05 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113110231.ixxeszux3d7agojv@ninjato \
--to=wsa@the-dreams.de \
--cc=dan.carpenter@oracle.com \
--cc=karl-heinz@schneider-inet.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox