From: Wolfram Sang <wsa@the-dreams.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit
Date: Mon, 27 Nov 2017 18:56:37 +0100 [thread overview]
Message-ID: <20171127175637.fmorzefw3bqfi56r@ninjato> (raw)
In-Reply-To: <20171102124731.10484-1-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Thu, Nov 02, 2017 at 01:47:26PM +0100, Wolfram Sang wrote:
> When clearing the ICE bit, all registers fall back to their defaut value. That
> allows for some simplifications in the code.
>
> Tested on a Renesas Lager board (R-Car H2) doing a bunch of consecutive
> commands. No spurious interrupts have been observed and the signals look
> exactly the same when visualized with sigrok.
>
> According to the docs, the ICE bit behaviour is the same since the beginning of
> this driver (sh7722) for the migo-r board.
>
> jacopo: can you please test this series while you work on migo-r anyhow? Thank
> you a ton for that!
>
> Looking forward to other comments, as well...
Whole series applied to i2c/for-next!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-27 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 12:47 [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit Wolfram Sang
2017-11-02 12:47 ` [PATCH RFT 1/5] i2c: sh_mobile: remove redundant initialization Wolfram Sang
2017-11-02 12:47 ` [PATCH RFT 2/5] i2c: sh_mobile: remove redundant deinitialization Wolfram Sang
2017-11-02 12:47 ` [PATCH RFT 3/5] i2c: sh_mobile: manually "inline" two short functions Wolfram Sang
2017-11-06 8:35 ` Geert Uytterhoeven
2017-11-06 8:54 ` Wolfram Sang
2017-11-02 12:47 ` [PATCH RFT 4/5] i2c: sh_mobile: use direct writes when accessing ICE bit Wolfram Sang
2017-11-02 12:47 ` [PATCH RFT 5/5] i2c: sh_mobile: shorten exit of xfer routine Wolfram Sang
2017-11-03 9:15 ` [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit jacopo mondi
2017-11-27 17:56 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127175637.fmorzefw3bqfi56r@ninjato \
--to=wsa@the-dreams.de \
--cc=jacopo@jmondi.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox