From: Andrzej Hajda <a.hajda@samsung.com>
To: Wolfram Sang <wsa@the-dreams.de>, Andi Shyti <andi.shyti@samsung.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"open list:I2C SUBSYSTEM" <linux-i2c@vger.kernel.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>
Subject: [PATCH 1/3] i2c: exynos5: change internal transmission timeout to 100ms
Date: Thu, 30 Nov 2017 15:30:05 +0100 [thread overview]
Message-ID: <20171130143007.30258-2-a.hajda@samsung.com> (raw)
In-Reply-To: <20171130143007.30258-1-a.hajda@samsung.com>
Exynos-I2C uses default timeout of 1 second for the whole transaction,
including re-transmissions due to arbitration lost errors (-EAGAIN).
To allow re-transmissions driver's internal timeout should be significantly
lower, 100ms seems to be good candidate.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/i2c/busses/i2c-exynos5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index 3855e0b11877..b02428498f6d 100644
--- a/drivers/i2c/busses/i2c-exynos5.c
+++ b/drivers/i2c/busses/i2c-exynos5.c
@@ -170,7 +170,7 @@
#define HSI2C_HS_TX_CLOCK 1000000
#define HSI2C_FS_TX_CLOCK 100000
-#define EXYNOS5_I2C_TIMEOUT (msecs_to_jiffies(1000))
+#define EXYNOS5_I2C_TIMEOUT (msecs_to_jiffies(100))
#define HSI2C_EXYNOS7 BIT(0)
--
2.15.0
next prev parent reply other threads:[~2017-11-30 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171130143017eucas1p172b94622814eff172a27176c82f6e6fe@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 0/3] i2c: exynos5: bus recovery implementation Andrzej Hajda
[not found] ` <CGME20171130143017eucas1p2f68094c72e4559e1a16cf334c3200950@eucas1p2.samsung.com>
2017-11-30 14:30 ` Andrzej Hajda [this message]
2018-01-15 20:54 ` [1/3] i2c: exynos5: change internal transmission timeout to 100ms Wolfram Sang
[not found] ` <CGME20171130143018eucas1p13bd2ce9263f9ac016ab3b779920b512e@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 2/3] i2c: exynos5: implement bus recovery functionality Andrzej Hajda
2018-01-15 20:52 ` [2/3] " Wolfram Sang
2018-01-16 8:35 ` Andrzej Hajda
2018-01-17 23:30 ` Wolfram Sang
[not found] ` <CGME20171130143018eucas1p1eba2c4f3361e0752cc53a25d217ce616@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 3/3] i2c: exynos5: do not check TRANS_STATUS in case of Exynos7 variant Andrzej Hajda
2018-01-15 20:53 ` [3/3] " Wolfram Sang
2018-01-16 9:40 ` Andrzej Hajda
2018-01-17 23:23 ` Wolfram Sang
2018-01-26 7:17 ` Andrzej Hajda
2018-01-26 9:30 ` Wolfram Sang
2017-12-07 7:36 ` [PATCH 0/3] i2c: exynos5: bus recovery implementation Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130143007.30258-2-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).