From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeprom: at24: code shrink
Date: Mon, 11 Dec 2017 09:08:48 +0100 [thread overview]
Message-ID: <20171211080848.t34igariuresgsvf@pengutronix.de> (raw)
In-Reply-To: <20171210192947.32211-1-brgl@bgdev.pl>
Hello,
On Sun, Dec 10, 2017 at 08:29:47PM +0100, Bartosz Golaszewski wrote:
> @@ -625,7 +610,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
> at24->offset_adj = at24_get_offset_adj(chip.flags, chip.byte_len);
>
> at24->client[0].client = client;
> - at24->client[0].regmap = devm_regmap_init_i2c(client, config);
> + at24->client[0].regmap = devm_regmap_init_i2c(client, &config);
> if (IS_ERR(at24->client[0].regmap))
> return PTR_ERR(at24->client[0].regmap);
>
One side effect here that the lockdep name changes from (unhelpful)
"config" to (unhelpful and ugly) "&config". Probably doesn't matter much
...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2017-12-11 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 19:29 [PATCH] eeprom: at24: code shrink Bartosz Golaszewski
2017-12-11 8:08 ` Uwe Kleine-König [this message]
2017-12-11 9:38 ` Bartosz Golaszewski
2017-12-18 17:45 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211080848.t34igariuresgsvf@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=brgl@bgdev.pl \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox