Re: [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency

Jean Delvare
2017-12-19T12:53:27Z

On Mon, 18 Dec 2017 16:11:37 +0200, maxin.john@gmail.com wrote:
> From: "Maxin B. John" <maxin.john@intel.com>
>
> Absence of this dependency caused parallel build to run into a race
> and break.
>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
> eeprog/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eeprog/Module.mk b/eeprog/Module.mk
> index 9d36869..d215855 100644
> --- a/eeprog/Module.mk
> +++ b/eeprog/Module.mk
> @@ -20,7 +20,7 @@ EEPROG_TARGETS := eeprog
> # Programs
> #
>
> -$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o
> +$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o $(LIB_DEPS)
> $(CC) $(LDFLAGS) -o $@ $^ $(EEPROG_LDFLAGS)
>
> #

Good catch, sorry for missing that one. Applied, thanks.

--
Jean Delvare
SUSE L3 Support