* [PATCH] lib/Module.mk: don't install dynamic library when disabled
@ 2018-01-02 5:00 Baruch Siach
2018-01-09 9:10 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2018-01-02 5:00 UTC (permalink / raw)
To: linux-i2c; +Cc: Jean Delvare, Baruch Siach, Angelo Compagnucci
Do not attempt to install the dynamic library when build of that library
is disabled. Fixes the following installation error:
install -m 755 lib/libi2c.so.0.1.0 .../target/usr/lib
install: cannot stat 'lib/libi2c.so.0.1.0': No such file or directory
lib/Module.mk:90: recipe for target 'install-lib' failed
Cc: Angelo Compagnucci <angelo@amarulasolutions.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
lib/Module.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/Module.mk b/lib/Module.mk
index 2ebc70d76ed9..c492961e0a4a 100644
--- a/lib/Module.mk
+++ b/lib/Module.mk
@@ -88,9 +88,11 @@ clean-lib:
install-lib: $(addprefix $(LIB_DIR)/,$(LIB_TARGETS))
$(INSTALL_DIR) $(DESTDIR)$(libdir)
+ifeq ($(BUILD_DYNAMIC_LIB),1)
$(INSTALL_PROGRAM) $(LIB_DIR)/$(LIB_SHLIBNAME) $(DESTDIR)$(libdir)
$(LN) $(LIB_SHLIBNAME) $(DESTDIR)$(libdir)/$(LIB_SHSONAME)
$(LN) $(LIB_SHSONAME) $(DESTDIR)$(libdir)/$(LIB_SHBASENAME)
+endif
ifeq ($(BUILD_STATIC_LIB),1)
$(INSTALL_DATA) $(LIB_DIR)/$(LIB_STLIBNAME) $(DESTDIR)$(libdir)
endif
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/Module.mk: don't install dynamic library when disabled
2018-01-02 5:00 [PATCH] lib/Module.mk: don't install dynamic library when disabled Baruch Siach
@ 2018-01-09 9:10 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2018-01-09 9:10 UTC (permalink / raw)
To: Baruch Siach; +Cc: linux-i2c, Angelo Compagnucci
Hi Baruch,
On Tue, 2 Jan 2018 07:00:30 +0200, Baruch Siach wrote:
> Do not attempt to install the dynamic library when build of that library
> is disabled. Fixes the following installation error:
>
> install -m 755 lib/libi2c.so.0.1.0 .../target/usr/lib
> install: cannot stat 'lib/libi2c.so.0.1.0': No such file or directory
> lib/Module.mk:90: recipe for target 'install-lib' failed
>
> Cc: Angelo Compagnucci <angelo@amarulasolutions.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> lib/Module.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/Module.mk b/lib/Module.mk
> index 2ebc70d76ed9..c492961e0a4a 100644
> --- a/lib/Module.mk
> +++ b/lib/Module.mk
> @@ -88,9 +88,11 @@ clean-lib:
>
> install-lib: $(addprefix $(LIB_DIR)/,$(LIB_TARGETS))
> $(INSTALL_DIR) $(DESTDIR)$(libdir)
> +ifeq ($(BUILD_DYNAMIC_LIB),1)
> $(INSTALL_PROGRAM) $(LIB_DIR)/$(LIB_SHLIBNAME) $(DESTDIR)$(libdir)
> $(LN) $(LIB_SHLIBNAME) $(DESTDIR)$(libdir)/$(LIB_SHSONAME)
> $(LN) $(LIB_SHSONAME) $(DESTDIR)$(libdir)/$(LIB_SHBASENAME)
> +endif
> ifeq ($(BUILD_STATIC_LIB),1)
> $(INSTALL_DATA) $(LIB_DIR)/$(LIB_STLIBNAME) $(DESTDIR)$(libdir)
> endif
Ugh, this avalanche of fix-up patches is getting embarrassing :(
Thanks for the fix, committed.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 5:00 [PATCH] lib/Module.mk: don't install dynamic library when disabled Baruch Siach
2018-01-09 9:10 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).