From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [Freedreno] [PATCH 2/2] drm/msm/adreno: fix nvmem related link error Date: Wed, 17 Jan 2018 14:21:03 -0700 Message-ID: <20180117212103.GA24386@jcrouse-lnx.qualcomm.com> References: <20180115161431.803248-1-arnd@arndb.de> <20180115161431.803248-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38752 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbeAQVVI (ORCPT ); Wed, 17 Jan 2018 16:21:08 -0500 Content-Disposition: inline In-Reply-To: <20180115161431.803248-2-arnd@arndb.de> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Arnd Bergmann Cc: Rob Clark , linux-fbdev@vger.kernel.org, Wolfram Sang , David Airlie , linux-arm-msm@vger.kernel.org, Bartlomiej Zolnierkiewicz , Archit Taneja , dri-devel@lists.freedesktop.org, Bjorn Andersson , Srinivas Kandagatla , linux-i2c@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org On Mon, Jan 15, 2018 at 05:14:05PM +0100, Arnd Bergmann wrote: > When NVMEM is configured as a loadable module, and adreno > is built-in, we get a link failure: > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_gpu_init': > a5xx_gpu.c:(.text+0x15cc): undefined reference to `nvmem_cell_get' > a5xx_gpu.c:(.text+0x15da): undefined reference to `nvmem_cell_read' > a5xx_gpu.c:(.text+0x15e4): undefined reference to `nvmem_cell_put' > > This adds a Kconfig dependency to enforce valid configurations, > when NVMEM is a loadable module, adreno now has to also be one. > The code seems to deal fine with nvmem being completely disabled, > it will just not set the right speed bin then, so we don't need > a hard dependency. > > Fixes: f56d9df656c4 ("drm/msm/adreno: Read the speed bins for a5xx targets") > Signed-off-by: Arnd Bergmann Reviewed-by: Jordan Crouse > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > index 99d39b2aefa6..74fb1c816da9 100644 > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -4,6 +4,7 @@ config DRM_MSM > depends on DRM > depends on ARCH_QCOM || (ARM && COMPILE_TEST) > depends on OF && COMMON_CLK > + depends on NVMEM || !NVMEM > depends on MMU > select QCOM_MDT_LOADER if ARCH_QCOM > select REGULATOR > -- > 2.9.0 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project