From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: Lixin Wang <alan.1.wang@nokia-sbell.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 2/5] i2c: of: make ref counting more visible
Date: Thu, 18 Jan 2018 13:11:30 +0100 [thread overview]
Message-ID: <20180118121133.13554-3-wsa@the-dreams.de> (raw)
In-Reply-To: <20180118121133.13554-1-wsa@the-dreams.de>
When debugging a ref counting problem, I overlooked this snipplet a few
times. Might be taste, but I think the new location is visually easier
recognizable.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-core-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
index b652579ed04e66..5e2d55b3daacca 100644
--- a/drivers/i2c/i2c-core-of.c
+++ b/drivers/i2c/i2c-core-of.c
@@ -64,8 +64,8 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
}
info.addr = addr;
- info.of_node = of_node_get(node);
info.archdata = &dev_ad;
+ info.of_node = of_node_get(node);
if (of_property_read_bool(node, "host-notify"))
info.flags |= I2C_CLIENT_HOST_NOTIFY;
--
2.11.0
next prev parent reply other threads:[~2018-01-18 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:11 [PATCH 0/5] i2c: of: brush up the code a little Wolfram Sang
2018-01-18 12:11 ` [PATCH 1/5] i2c: of: change log level of failed device creation Wolfram Sang
2018-01-18 12:11 ` Wolfram Sang [this message]
2018-01-18 12:11 ` [PATCH 3/5] i2c: of: rename variable to meet expectations Wolfram Sang
2018-01-18 12:11 ` [PATCH 4/5] i2c: of: remove duplicated check for valid address Wolfram Sang
2018-01-18 12:11 ` [PATCH 5/5] i2c: of: simplify reading the "reg" property Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118121133.13554-3-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=alan.1.wang@nokia-sbell.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).