From: Wolfram Sang <wsa@the-dreams.de>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Andi Shyti <andi.shyti@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"open list:I2C SUBSYSTEM" <linux-i2c@vger.kernel.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [3/3] i2c: exynos5: do not check TRANS_STATUS in case of Exynos7 variant
Date: Fri, 26 Jan 2018 10:30:31 +0100 [thread overview]
Message-ID: <20180126093030.4uhpnpyzz3hccptz@katana> (raw)
In-Reply-To: <5e27b754-17fa-3a98-0a99-ba93c16e5c0e@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
Hi Andrzej,
> Forgive me delayed response - holiday.
No worries!
> The code removed was something extra, so I am not sure if it is
> necessary to add comment to the code, git log should be enough.
If somebody later discovers this "new bit" and implements support for
it, I am not sure this person will check git log to see if there has
ever been support added and later removed. Also, it helps me reviewing
when gory details are explicitly mentioned in the code.
> Anyway I will post patches dealing with HSI2C_MASTER_ST_LOSE on
> transaction start very soon, so I can add relevant comment there.
Please do.
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-26 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171130143017eucas1p172b94622814eff172a27176c82f6e6fe@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 0/3] i2c: exynos5: bus recovery implementation Andrzej Hajda
[not found] ` <CGME20171130143017eucas1p2f68094c72e4559e1a16cf334c3200950@eucas1p2.samsung.com>
2017-11-30 14:30 ` [PATCH 1/3] i2c: exynos5: change internal transmission timeout to 100ms Andrzej Hajda
2018-01-15 20:54 ` [1/3] " Wolfram Sang
[not found] ` <CGME20171130143018eucas1p13bd2ce9263f9ac016ab3b779920b512e@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 2/3] i2c: exynos5: implement bus recovery functionality Andrzej Hajda
2018-01-15 20:52 ` [2/3] " Wolfram Sang
2018-01-16 8:35 ` Andrzej Hajda
2018-01-17 23:30 ` Wolfram Sang
[not found] ` <CGME20171130143018eucas1p1eba2c4f3361e0752cc53a25d217ce616@eucas1p1.samsung.com>
2017-11-30 14:30 ` [PATCH 3/3] i2c: exynos5: do not check TRANS_STATUS in case of Exynos7 variant Andrzej Hajda
2018-01-15 20:53 ` [3/3] " Wolfram Sang
2018-01-16 9:40 ` Andrzej Hajda
2018-01-17 23:23 ` Wolfram Sang
2018-01-26 7:17 ` Andrzej Hajda
2018-01-26 9:30 ` Wolfram Sang [this message]
2017-12-07 7:36 ` [PATCH 0/3] i2c: exynos5: bus recovery implementation Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126093030.4uhpnpyzz3hccptz@katana \
--to=wsa@the-dreams.de \
--cc=a.hajda@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).