From: "Michał Kępień" <kernel@kempniu.pl>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Wolfram Sang <wsa@the-dreams.de>,
Steven Honeyman <stevenhoneyman@gmail.com>,
Valdis.Kletnieks@vt.edu,
Jochen Eisinger <jochen@penguin-breeder.org>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Mario_Limonciello@dell.com, Alex Hung <alex.hung@canonical.com>,
Takashi Iwai <tiwai@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines
Date: Sun, 11 Feb 2018 23:03:17 +0100 [thread overview]
Message-ID: <20180211220317.GA833@kmp-mobile.hq.kempniu.pl> (raw)
In-Reply-To: <20180127133209.28995-1-pali.rohar@gmail.com>
> Dell platform team told us that some (DMI whitelisted) Dell Latitude
> machines have ST microelectronics accelerometer at i2c address 0x29.
>
> Presence of that ST microelectronics accelerometer is verified by existence
> of SMO88xx ACPI device which represent that accelerometer. Unfortunately
> ACPI device does not specify i2c address.
>
> This patch registers lis3lv02d device for selected Dell Latitude machines
> at i2c address 0x29 after detection. And for Dell Vostro V131 machine at
> i2c address 0x1d which was manually detected.
>
> Finally commit a7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to
> conflict with PCI BAR") allowed to use i2c-i801 driver on Dell machines so
> lis3lv02d correctly initialize accelerometer.
>
> Tested on Dell Latitude E6440.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> Changes since v1:
> * Added Dell Vostro V131 based on Michał Kępień testing
I tested this patch on a Vostro V131 and it seems to work as expected:
"lis3lv02d: 8 bits sensor found" is logged during boot, an input device
gets registered and its axis values seem to be consistent with laptop's
movements.
Tested-by: Michał Kępień <kernel@kempniu.pl>
I did not review the contents of the patch this time, sorry.
--
Best regards,
Michał Kępień
next prev parent reply other threads:[~2018-02-11 22:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 13:32 [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2018-01-28 14:39 ` Andy Shevchenko
2018-01-28 14:45 ` Pali Rohár
2018-01-28 15:00 ` Andy Shevchenko
2018-01-31 12:03 ` Pali Rohár
2018-01-31 12:27 ` Andy Shevchenko
2018-02-12 15:30 ` Pali Rohár
2018-02-13 14:55 ` Andy Shevchenko
2018-02-13 15:00 ` Pali Rohár
2018-02-13 15:06 ` Andy Shevchenko
2018-02-13 16:50 ` Pali Rohár
2018-02-13 17:01 ` Andy Shevchenko
2018-02-13 17:05 ` Andy Shevchenko
2018-02-26 20:32 ` Wolfram Sang
2018-03-08 22:53 ` Pali Rohár
2018-04-18 11:46 ` Pali Rohár
2019-04-27 6:48 ` Pali Rohár
2019-05-28 9:19 ` Jean Delvare
2019-05-28 9:41 ` Pali Rohár
2019-05-28 9:50 ` Jean Delvare
2019-05-28 9:54 ` Pali Rohár
2019-05-28 10:00 ` Jean Delvare
2018-02-11 22:03 ` Michał Kępień [this message]
2018-02-12 15:25 ` Andy Shevchenko
2019-06-02 13:20 ` [PATCH v3] " Pali Rohár
2019-06-04 14:57 ` Jean Delvare
2019-06-04 22:30 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211220317.GA833@kmp-mobile.hq.kempniu.pl \
--to=kernel@kempniu.pl \
--cc=Mario_Limonciello@dell.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alex.hung@canonical.com \
--cc=gabriele.mzt@gmail.com \
--cc=jdelvare@suse.com \
--cc=jochen@penguin-breeder.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stevenhoneyman@gmail.com \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).