From: Wolfram Sang <wsa@the-dreams.de>
To: Colin King <colin.king@canonical.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-stm32f4: remove redundant initialization of pointer reg
Date: Mon, 26 Feb 2018 21:06:39 +0100 [thread overview]
Message-ID: <20180226200639.tfll2y4efepm2sos@ninjato> (raw)
In-Reply-To: <20180116174404.19464-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]
On Tue, Jan 16, 2018 at 05:44:04PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer reg is assigned a value that is never read, it is later
> overwritten with a new value, hence the redundant initialization can
> be removed.
>
> Cleans up clang warning:
> drivers/i2c/busses/i2c-stm32f4.c:352:16: warning: Value stored to 'reg'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Maxime? Alexandre? Are you OK with this patch?
> ---
> drivers/i2c/busses/i2c-stm32f4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 47c8d00de53f..ba600d77a3f8 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -349,7 +349,7 @@ static void stm32f4_i2c_read_msg(struct stm32f4_i2c_dev *i2c_dev)
> static void stm32f4_i2c_terminate_xfer(struct stm32f4_i2c_dev *i2c_dev)
> {
> struct stm32f4_i2c_msg *msg = &i2c_dev->msg;
> - void __iomem *reg = i2c_dev->base + STM32F4_I2C_CR2;
> + void __iomem *reg;
>
> stm32f4_i2c_disable_irq(i2c_dev);
>
> --
> 2.15.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-26 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 17:44 [PATCH] i2c-stm32f4: remove redundant initialization of pointer reg Colin King
2018-02-26 20:06 ` Wolfram Sang [this message]
2018-02-27 7:44 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226200639.tfll2y4efepm2sos@ninjato \
--to=wsa@the-dreams.de \
--cc=alexandre.torgue@st.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox