From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2 2/2] i2c: piix4: Use request_muxed_region Date: Mon, 26 Feb 2018 14:28:58 -0800 Message-ID: <20180226222858.GB5924@roeck-us.net> References: <1519678013-32749-1-git-send-email-linux@roeck-us.net> <1519678013-32749-2-git-send-email-linux@roeck-us.net> <20180226205204.p37lf7dcl5k7az37@ninjato> <20180226213406.GB2211@roeck-us.net> <20180226214307.irourq2svpd7ok7e@ninjato> <20180226214414.6jbloibqkidr66de@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180226214414.6jbloibqkidr66de@ninjato> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Jean Delvare , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Zoltan Boszormenyi List-Id: linux-i2c@vger.kernel.org On Mon, Feb 26, 2018 at 10:44:14PM +0100, Wolfram Sang wrote: > On Mon, Feb 26, 2018 at 10:43:07PM +0100, Wolfram Sang wrote: > > > > > It is an alternate and somewhat simpler solution which does not > > > attempt to change the kernel API. My primary goal was to find > > > a solution for the immediate problem between the watchdog and > > > i2c drivers. My solution does not attempt to fix the access problem > > > for (initialization) functions with no return code. At the same time, > > > I prefer to use functions which _do_ return an error if that is possible > > > since it _may_ after all be that there are other users calling > > > request_region(). > > > > > > Having said that, I'll be just as happy if Zoltan's series is accepted > > > instead of this patch (except for patch #5; the watchdog driver has > > > already been converted to use request_muxed_region). > > > > Thanks for the explanation! > > > > So, as I understand: I can apply this patch to fix the immediate (and > > long standing) problem and decouple it from the API change. The latter > > can then still be worked on and the changes for the piix driver should > > then be minimal. Correct? > > And we should have Zoltan on CC. > Yes. Sorry, things are a bit hectic today. Guenter