Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

Dan Carpenter
2018-03-02T11:02:12Z

On Fri, Mar 02, 2018 at 02:00:03PM +0300, Dan Carpenter wrote:
> On Fri, Mar 02, 2018 at 11:29:26AM +0100, Wolfram Sang wrote:
> > On Thu, Mar 01, 2018 at 09:34:44PM +0100, Krzysztof Kozlowski wrote:
> > > Interrupt number 0 (returned by platform_get_irq()) might be a valid IRQ
> > > so do not treat it as an error. If interrupt 0 was configured, the driver
> > > would exit the probe early, before finishing initialization, but with
> > > 0-exit status.
> > >
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Cc: stable@vger.kernel.org
> > > Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
> >
> > Please configure git to use 14 digits here.
>
> Wait, when did we decide that 12 wasn't enough?
>
> I just did a `git log | grep Fixes | tee baz | head -n 200` and only on
> my git tree tehre were only 2 which used exactly 14 digits. The
> standard is 12.

Wow... I clearly did not read that email before sending it... :(

regards,
dan carpenter