* Re: [PATCH] i2c: tegra: Fix PM device usage count
[not found] <20180224224423.hz36gpxnlpex2cqx@agrajag.zerfleddert.de>
@ 2018-03-14 12:10 ` Thierry Reding
0 siblings, 0 replies; only message in thread
From: Thierry Reding @ 2018-03-14 12:10 UTC (permalink / raw)
To: Tobias Jordan
Cc: linux-i2c, linux-tegra, linux-kernel, Laxman Dewangan,
Wolfram Sang, Jonathan Hunter
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Sat, Feb 24, 2018 at 11:44:23PM +0100, Tobias Jordan wrote:
> pm_runtime_get_sync() increases the device's usage count even when
> reporting an error, so add a call to pm_runtime_put_noidle() in the
> related error branches.
>
> Fixes: 1f50ad2c86cd ("i2c: tegra: Add runtime power-management support")
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> ---
> This is one of a number of patches for problems found using coccinelle
> scripting in the SIL2LinuxMP project. The patch has been compile-tested;
> it's based on linux-next-20180223.
>
> For a discussion of the corresponding issue, see
> https://marc.info/?l=linux-pm&m=151904483924999&w=2
>
> drivers/i2c/busses/i2c-tegra.c | 2 ++
> 1 file changed, 2 insertions(+)
This seems okay to me, though given the discussion it might be
preferable to just ignore errors rather than fail.
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] only message in thread