From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 03/21] eeprom: at24: arrange local variables Date: Fri, 23 Mar 2018 17:37:00 +0100 Message-ID: <20180323163700.GA5063@kroah.com> References: <20180319091721.18193-1-brgl@bgdev.pl> <20180319091721.18193-4-brgl@bgdev.pl> <20180323152157.GA6934@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bartosz Golaszewski Cc: Arnd Bergmann , linux-i2c , Linux Kernel Mailing List List-Id: linux-i2c@vger.kernel.org On Fri, Mar 23, 2018 at 05:06:30PM +0100, Bartosz Golaszewski wrote: > 2018-03-23 16:21 GMT+01:00 Greg Kroah-Hartman : > > On Mon, Mar 19, 2018 at 10:17:03AM +0100, Bartosz Golaszewski wrote: > >> Arrange declarations of local variables by line length as visually > >> it's easier to read. > > > > That's the craziest thing I've seen in a while... > > > > ok, if it makes it easier for you :) > > > > greg k-h > > Hi Greg, > > this isn't something unusual, see for example: > > bef6b1b7a6ff ("nfp: reorder variables in nfp_net_tx()") > 5318c53d5b4b ("crypto: s5p-sss - Use consistent indentation for > variables and members") I still say it is crazy :)