From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: wsa@the-dreams.de
Cc: andy.shevchenko@gmail.com, jassisinghbrar@gmail.com,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v6 3/3] i2c: add param sanity check to i2c_transfer()
Date: Sun, 25 Mar 2018 12:07:47 +0100 [thread overview]
Message-ID: <20180325110747.8852-4-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20180325110747.8852-1-ard.biesheuvel@linaro.org>
The API docs describe i2c_transfer() as taking a pointer to an array
of i2c_msg containing at least 1 entry, but leaves it to the individual
drivers to sanity check the msgs and num parameters. Let's do this in
core code instead.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/i2c/i2c-core-base.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index c8bfe008f208..dfc549cf0ac2 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1845,6 +1845,9 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
unsigned long orig_jiffies;
int ret, try;
+ if (!msgs || num < 1)
+ return -EINVAL;
+
if (adap->quirks && i2c_check_for_quirks(adap, msgs, num))
return -EOPNOTSUPP;
--
2.15.1
next prev parent reply other threads:[~2018-03-25 11:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 11:07 [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-03-25 11:07 ` [PATCH v6 1/3] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-04-04 18:33 ` Wolfram Sang
2018-04-04 18:34 ` Wolfram Sang
2018-03-25 11:07 ` [PATCH v6 2/3] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-04 18:34 ` Wolfram Sang
2018-04-04 18:35 ` Wolfram Sang
2018-03-25 11:07 ` Ard Biesheuvel [this message]
2018-04-03 15:03 ` [PATCH v6 3/3] i2c: add param sanity check to i2c_transfer() Wolfram Sang
2018-04-03 16:56 ` Ard Biesheuvel
2018-03-30 14:13 ` [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-03 15:01 ` Wolfram Sang
2018-04-03 18:05 ` Ard Biesheuvel
2018-04-03 18:12 ` Wolfram Sang
2018-04-03 18:14 ` Ard Biesheuvel
2018-04-03 18:32 ` Wolfram Sang
2018-04-03 18:35 ` Ard Biesheuvel
[not found] ` <20180403184559.z5lixuheqd4ojoti@ninjato>
2018-04-03 18:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325110747.8852-4-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).