From: Wolfram Sang <wsa@the-dreams.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller
Date: Tue, 3 Apr 2018 20:12:16 +0200 [thread overview]
Message-ID: <20180403181216.f22vtkqrnxjgreuo@ninjato> (raw)
In-Reply-To: <CAKv+Gu9cqQqq_etTSvdBp4Jjk5O_0FePe74phDqt5EO6Cm-_vQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 392 bytes --]
> Yeah, good point. So when exactly should this be called? Only on error
> conditions that could be caused by a misbehaving slave?
Chapter 3.1.16 of the I2C specification, only when a slave keeps SDA
low. Usually you detect that before you start transmitting.
Really, please remove it for now and add it later, properly tested!
BTW what kind of tests did you do with this driver so far?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-04-03 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 11:07 [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-03-25 11:07 ` [PATCH v6 1/3] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-04-04 18:33 ` Wolfram Sang
2018-04-04 18:34 ` Wolfram Sang
2018-03-25 11:07 ` [PATCH v6 2/3] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-04 18:34 ` Wolfram Sang
2018-04-04 18:35 ` Wolfram Sang
2018-03-25 11:07 ` [PATCH v6 3/3] i2c: add param sanity check to i2c_transfer() Ard Biesheuvel
2018-04-03 15:03 ` Wolfram Sang
2018-04-03 16:56 ` Ard Biesheuvel
2018-03-30 14:13 ` [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-04-03 15:01 ` Wolfram Sang
2018-04-03 18:05 ` Ard Biesheuvel
2018-04-03 18:12 ` Wolfram Sang [this message]
2018-04-03 18:14 ` Ard Biesheuvel
2018-04-03 18:32 ` Wolfram Sang
2018-04-03 18:35 ` Ard Biesheuvel
[not found] ` <20180403184559.z5lixuheqd4ojoti@ninjato>
2018-04-03 18:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403181216.f22vtkqrnxjgreuo@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).