From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v2 3/3] Documentation/i2c: adopt kernel commenting style
 in examples
Date: Fri, 13 Apr 2018 18:50:00 +0200
Message-ID: <20180413165000.2svg2j5ozdd2egbd@ninjato>
References: <CAP9bUy7rONNHYeRkYtaWHcfqoZcGKXJz-JocED26zBj9n+-ZbQ@mail.gmail.com>
 <20180413164405.127522-1-hansens@google.com>
 <20180413164405.127522-3-hansens@google.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pttm4h4pxs432wix"
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180413164405.127522-3-hansens@google.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Sam Hansen <hansens@google.com>
Cc: linux-i2c@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: linux-i2c@vger.kernel.org


--pttm4h4pxs432wix
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


> -  int adapter_nr = 2; /* probably dynamically determined */

Such comments are actually OK.

> -    /* ERROR HANDLING; you can check errno to see what went wrong */

Such as well.

> -  /* Using I2C Write, equivalent of
> -     i2c_smbus_write_word_data(file, reg, 0x6543) */
> +  /*
> +   * Using I2C Write, equivalent of
> +   * i2c_smbus_write_word_data(file, reg, 0x6543).
> +   */

This is the only broken one AFAICT.


--pttm4h4pxs432wix
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlrQ37QACgkQFA3kzBSg
Kbb8phAAlunAC0S+3NuaC4xXkaJGt/5gM4CKXPpL7LyauKyz5J4MD1fPAYDgLwBM
VWFbr9/MRB57unWdYw5/0qCKq/X+R8wPm+05cP7V1hSxUk2aTexKjPDRAfsA0rH4
1/wygiCybrBKXf5Bcado2jTxPYhRBNarLlhiAPsvGIyYqY0cf8Y2CZsAony9fssa
trCLbaljHWm2EEiZVIp5Uvt5nOJ5dSkNppA+dv1Uxx74Lo9/3Blj6GvSYqtJkwek
qNqCTIcLw7QuDVb2qPlGpJ1wxpaXt9HPQsJu2RIuY31qIC2NbIw6HPDYJm7cLGul
X9rhSZZFX3MjI2pulkQ23ofEY7OfHCVZ/g0JkPAl3AgEMnRejc0DDfkL4cqp7D/y
QKICf/jMW52mvfDqtFahAQCezgXxrB9j19Bw9RRVyJmGJudvP3J4GJZes6If1BSc
NJL6ya8p0vqgToRwQPBdYKMrX3HM0hkrpzjV4UX02YhrArInHDb0DR0cd4+2dRHI
9P0ZwYqQ8HhqAFek9VrsLPbroaoJ6Ff3et6gIddObCzHEHhtAVJ46UIlIhzWNvGC
Q336caSDFht0+IXuFZ9RUom0DMMzoKXA6KfydsHTigAJzm4dExXz/HaF4nRWgS0/
vMO8q+5hhGo/XIB183F2zzgj0YYnnB1yQGhmFY8Es8phD802xMo=
=HnGa
-----END PGP SIGNATURE-----

--pttm4h4pxs432wix--