From: Jean Delvare <jdelvare@suse.de>
To: Sam Hansen <hansens@google.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/i2c: sync docs with current state of i2c-tools.
Date: Fri, 13 Apr 2018 20:49:37 +0200 [thread overview]
Message-ID: <20180413204937.440437e9@endymion> (raw)
In-Reply-To: <CAP9bUy7rONNHYeRkYtaWHcfqoZcGKXJz-JocED26zBj9n+-ZbQ@mail.gmail.com>
On Fri, 13 Apr 2018 09:02:03 -0700, Sam Hansen wrote:
> On Fri, Apr 13, 2018 at 5:13 AM, Jean Delvare <jdelvare@suse.de> wrote:
> > On Fri, 13 Apr 2018 00:24:57 +0200, Wolfram Sang wrote:
> >> On Thu, Apr 12, 2018 at 02:33:42PM -0700, Sam Hansen wrote:
> >> > - Not meant to be called directly; instead, use the access functions
> >> > - below.
> >> > + If possible, use the provided i2c_smbus_* methods described below in favor
> >> > + of issuing direct ioctls.
> >>
> >> Why this change?
> >
> > I'm also not sure if "in favor of" is right. "instead of" would sound
> > better to me, but I'm no native English speaker, I could be wrong.
>
> Sounds good, I'll adopt "instead of". Regarding Wolfram's earlier
> comment, as an engineer, requiring an out-of-tree library to build
> drivers felt a little off. I can revert this section if you want,
> just let me know.
The i2c dev interface, and the overlaying library, are used by
user-space applications. This has nothing to do with "building
drivers", and makes your "out-of-tree" objection irrelevant. I doubt
libi2c is the only user-space library building on top of a kernel
interface.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2018-04-13 18:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 21:33 [PATCH] Documentation/i2c: sync docs with current state of i2c-tools Sam Hansen
2018-04-12 22:24 ` Wolfram Sang
2018-04-13 12:13 ` Jean Delvare
2018-04-13 16:02 ` Sam Hansen
2018-04-13 16:44 ` [PATCH v2 1/3] Documentation/i2c: whitespace cleanup Sam Hansen
2018-04-13 16:44 ` [PATCH v2 2/3] Documentation/i2c: sync docs with current state of i2c-tools Sam Hansen
2018-04-13 16:50 ` Wolfram Sang
2018-04-13 16:44 ` [PATCH v2 3/3] Documentation/i2c: adopt kernel commenting style in examples Sam Hansen
2018-04-13 16:50 ` Wolfram Sang
2018-04-13 17:39 ` Sam Hansen
2018-04-13 16:50 ` [PATCH v2 1/3] Documentation/i2c: whitespace cleanup Wolfram Sang
2018-04-13 18:49 ` Jean Delvare [this message]
2018-04-13 23:32 ` [PATCH] Documentation/i2c: sync docs with current state of i2c-tools Sam Hansen
2018-04-14 6:27 ` Wolfram Sang
2018-04-17 19:17 ` Sam Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413204937.440437e9@endymion \
--to=jdelvare@suse.de \
--cc=corbet@lwn.net \
--cc=hansens@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).