From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mfd: tps6586x: Move interrupt handling into workqueue
Date: Mon, 14 May 2018 13:51:35 +0200 [thread overview]
Message-ID: <20180514115135.GG18312@ulmo> (raw)
In-Reply-To: <20180513211842.7819-1-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Mon, May 14, 2018 at 12:18:42AM +0300, Dmitry Osipenko wrote:
> Reading of status register within the interrupt handler fails with -EAGAIN
> if I2C is busy with handling some other request at the same time. Move the
> actual interrupt handling into a workqueue to avoid the unfortunate I2C
> failure and to avoid hanging CPU in interrupt up to 1 second (transfer
> timeout in the Tegra I2C driver).
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/mfd/tps6586x.c | 40 +++++++++++++++++++++++++++++-----------
> 1 file changed, 29 insertions(+), 11 deletions(-)
Could this not be achieved with a threaded interrupt handler?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-14 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 21:18 [PATCH v1] mfd: tps6586x: Move interrupt handling into workqueue Dmitry Osipenko
2018-05-14 11:51 ` Thierry Reding [this message]
2018-05-14 12:01 ` Dmitry Osipenko
2018-05-14 12:20 ` Dmitry Osipenko
2018-05-14 12:39 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514115135.GG18312@ulmo \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).