From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 07/21] i2c: efm32: make use of i2c_8bit_addr_from_msg Date: Mon, 14 May 2018 20:27:24 +0200 Message-ID: <20180514182724.sw3c4xmq5av4pphf@pengutronix.de> References: <20180514145330.4857-1-peda@axentia.se> <20180514145330.4857-8-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180514145330.4857-8-peda@axentia.se> Sender: linux-kernel-owner@vger.kernel.org To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org List-Id: linux-i2c@vger.kernel.org Hello Peter, On Mon, May 14, 2018 at 04:53:16PM +0200, Peter Rosin wrote: > Because it looks neater. > > Signed-off-by: Peter Rosin > --- > drivers/i2c/busses/i2c-efm32.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c > index aa336ba89aa3..5f2bab878b2c 100644 > --- a/drivers/i2c/busses/i2c-efm32.c > +++ b/drivers/i2c/busses/i2c-efm32.c > @@ -144,8 +144,7 @@ static void efm32_i2c_send_next_msg(struct efm32_i2c_ddata *ddata) > struct i2c_msg *cur_msg = &ddata->msgs[ddata->current_msg]; > > efm32_i2c_write32(ddata, REG_CMD, REG_CMD_START); > - efm32_i2c_write32(ddata, REG_TXDATA, cur_msg->addr << 1 | > - (cur_msg->flags & I2C_M_RD ? 1 : 0)); > + efm32_i2c_write32(ddata, REG_TXDATA, i2c_8bit_addr_from_msg(cur_msg)); Nice, Acked-by: Uwe Kleine-König Best regards and thanks, Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |