From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: robotfuzz-osif: drop pointless test
Date: Thu, 24 May 2018 22:17:17 +0200 [thread overview]
Message-ID: <20180524201717.tyzatx7nvxwanb3f@ninjato> (raw)
In-Reply-To: <20180509194658.29106-2-peda@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
On Wed, May 09, 2018 at 09:46:58PM +0200, Peter Rosin wrote:
> In the for-loop test, ret will be either 0 or 1. So, the
> comparison is pointless. Drop it, and drop the initializer
> which is then also pointless.
>
> Signed-off-by: Peter Rosin <peda@axentia.se>
Applied to for-next, thanks!
Reading that function, it also seems this driver wrongly sends a STOP
after every message of a transfer. And not just at the end of the
transfer :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-24 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 19:46 [PATCH 1/2] i2c: robotfuzz-osif: remove pointless local variable Peter Rosin
2018-05-09 19:46 ` [PATCH 2/2] i2c: robotfuzz-osif: drop pointless test Peter Rosin
2018-05-24 20:17 ` Wolfram Sang [this message]
2018-05-24 20:15 ` [PATCH 1/2] i2c: robotfuzz-osif: remove pointless local variable Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524201717.tyzatx7nvxwanb3f@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox